Added rendering benchmark javascript hook

content/public/renderer/all_rendering_benchmarks.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_RENDERER_ALL_RENDERING_BENCHMARKS_H_
+#define CONTENT_PUBLIC_RENDERER_ALL_RENDERING_BENCHMARKS_H_
+
+#include <string>
+
+#include "base/basictypes.h"

[nduca, 2012/07/18 06:06:17]

why?

[dmurph, 2012/07/18 20:01:57]

DISALLOW_COPY_AND_ASSIGN, which I'm adding

+#include "base/compiler_specific.h"

[nduca, 2012/07/18 06:06:17]

why?

[dmurph, 2012/07/18 16:31:41]

for OVERRIDE

+#include "content/common/content_export.h"

[nduca, 2012/07/18 06:06:17]

why?

[dmurph, 2012/07/18 20:01:57]

Done.

+#include "content/public/renderer/rendering_benchmark.h"
+#include "content/public/renderer/rendering_benchmark_results.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebViewBenchmarkSupport.h"
+

[nduca, 2012/07/18 06:06:17]

Include only when you need it.

You can predeclare almost everything here.

E.g you dont even need rendering_benhchmark results or header. just say

class RenderingBenchmark and you'll be all set.

[dmurph, 2012/07/18 16:31:41]

Yeah, I forgot to clean these up, sorry

+namespace content {
+class CONTENT_EXPORT AllRenderingBenchmarks : public RenderingBenchmark {

[nduca, 2012/07/18 06:06:17]

Why oh why another subclass? Why not just return a vector of constructed
benchmarks that are in this file? That'd be much much simpler.

scoped_vector<RendererBenchmark> getAllRenderingBenchmarks()?

[dmurph, 2012/07/18 20:01:57]

Is it cool if we do getter-style of 'benchmarks()'?  The 'all' part is a little
redundant, given the class name.

+ public:
+  AllRenderingBenchmarks(RenderingBenchmarkResults* results,
+                         const std::string& name_filter);
+  virtual ~AllRenderingBenchmarks();
+
+  virtual void Run(WebKit::WebViewBenchmarkSupport*) OVERRIDE;
+
+ private:
+  const std::string name_filter_;
+  RenderingBenchmark** benchmarks_;

[nduca, 2012/07/18 06:06:17]

Eep! scoped_vector is your friend. But as I pointed out, this whole class should
go away.

[dmurph, 2012/07/18 16:31:41]

Yeah I know

+  const int benchmark_count_;

[nduca, 2012/07/18 06:06:17]

You're too obsessive about const. Please, save us the time. Stop using it unless
someone tells you to do so in codereview, or on simple accessors.

[dmurph, 2012/07/18 20:01:57]

Done.

+};
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_RENDERER_ALL_RENDERING_BENCHMARKS_H_