Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 10537022: Temporary fix for Infolist font issue. (Closed)

Created:
8 years, 6 months ago by horo
Modified:
8 years, 6 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Temporary fix for Infolist font issue. BUG=129507 TEST=gmerge passes,manually done Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141171

Patch Set 1 #

Total comments: 3

Patch Set 2 : Support Chromium OS #

Total comments: 11

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M chrome/browser/chromeos/input_method/candidate_window.cc View 1 2 4 chunks +20 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_view.h View 1 2 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
horo
8 years, 6 months ago (2012-06-06 06:13:55 UTC) #1
Seigo Nonaka
https://chromiumcodereview.appspot.com/10537022/diff/1/chrome/browser/chromeos/input_method/candidate_window.cc File chrome/browser/chromeos/input_method/candidate_window.cc (right): https://chromiumcodereview.appspot.com/10537022/diff/1/chrome/browser/chromeos/input_method/candidate_window.cc#newcode1370 chrome/browser/chromeos/input_method/candidate_window.cc:1370: description_font_(new gfx::Font("MotoyaG04Gothic", kFontSizeDelta + 11)) { IIRC Motoya font ...
8 years, 6 months ago (2012-06-06 06:20:16 UTC) #2
Yusuke Sato
drive-by: https://chromiumcodereview.appspot.com/10537022/diff/1/chrome/browser/chromeos/input_method/candidate_window.cc File chrome/browser/chromeos/input_method/candidate_window.cc (right): https://chromiumcodereview.appspot.com/10537022/diff/1/chrome/browser/chromeos/input_method/candidate_window.cc#newcode1370 chrome/browser/chromeos/input_method/candidate_window.cc:1370: description_font_(new gfx::Font("MotoyaG04Gothic", kFontSizeDelta + 11)) { On 2012/06/06 ...
8 years, 6 months ago (2012-06-07 05:16:19 UTC) #3
horo
https://chromiumcodereview.appspot.com/10537022/diff/1/chrome/browser/chromeos/input_method/candidate_window.cc File chrome/browser/chromeos/input_method/candidate_window.cc (right): https://chromiumcodereview.appspot.com/10537022/diff/1/chrome/browser/chromeos/input_method/candidate_window.cc#newcode1370 chrome/browser/chromeos/input_method/candidate_window.cc:1370: description_font_(new gfx::Font("MotoyaG04Gothic", kFontSizeDelta + 11)) { On 2012/06/07 05:16:19, ...
8 years, 6 months ago (2012-06-08 02:09:56 UTC) #4
Seigo Nonaka
lgtm LGTM with nits. https://chromiumcodereview.appspot.com/10537022/diff/6001/chrome/browser/chromeos/input_method/candidate_window.cc File chrome/browser/chromeos/input_method/candidate_window.cc (right): https://chromiumcodereview.appspot.com/10537022/diff/6001/chrome/browser/chromeos/input_method/candidate_window.cc#newcode69 chrome/browser/chromeos/input_method/candidate_window.cc:69: // TODO: Currently the infolist ...
8 years, 6 months ago (2012-06-08 02:17:38 UTC) #5
Yusuke Sato
drive-by: http://codereview.chromium.org/10537022/diff/6001/chrome/browser/chromeos/input_method/candidate_window.cc File chrome/browser/chromeos/input_method/candidate_window.cc (right): http://codereview.chromium.org/10537022/diff/6001/chrome/browser/chromeos/input_method/candidate_window.cc#newcode69 chrome/browser/chromeos/input_method/candidate_window.cc:69: // TODO: Currently the infolist window only supports ...
8 years, 6 months ago (2012-06-08 02:22:42 UTC) #6
horo
http://codereview.chromium.org/10537022/diff/6001/chrome/browser/chromeos/input_method/candidate_window.cc File chrome/browser/chromeos/input_method/candidate_window.cc (right): http://codereview.chromium.org/10537022/diff/6001/chrome/browser/chromeos/input_method/candidate_window.cc#newcode69 chrome/browser/chromeos/input_method/candidate_window.cc:69: // TODO: Currently the infolist window only supports Japanese ...
8 years, 6 months ago (2012-06-08 03:01:12 UTC) #7
Yusuke Sato
lgtm On 2012/06/08 03:01:12, horo wrote: > http://codereview.chromium.org/10537022/diff/6001/chrome/browser/chromeos/input_method/candidate_window.cc > File chrome/browser/chromeos/input_method/candidate_window.cc (right): > > http://codereview.chromium.org/10537022/diff/6001/chrome/browser/chromeos/input_method/candidate_window.cc#newcode69 ...
8 years, 6 months ago (2012-06-08 03:08:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/10537022/11001
8 years, 6 months ago (2012-06-08 03:11:01 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 04:53:31 UTC) #10
Change committed as 141171

Powered by Google App Engine
This is Rietveld 408576698