Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5776)

Unified Diff: chrome/test/data/extensions/api_test/socket/api/background.js

Issue 10537017: Allow hostnames in socket.connect(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Patch Set 1 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/socket/api/background.js
diff --git a/chrome/test/data/extensions/api_test/socket/api/background.js b/chrome/test/data/extensions/api_test/socket/api/background.js
index f6a29fd05a9929c640af093086befa5411501ddf..be7436fc0ebaca51c4aaa2595d23b857506e3fa4 100644
--- a/chrome/test/data/extensions/api_test/socket/api/background.js
+++ b/chrome/test/data/extensions/api_test/socket/api/background.js
@@ -81,32 +81,33 @@ function onWriteOrSendToComplete(writeInfo) {
}
}
-function onConnectOrBindComplete(result) {
- chrome.test.assertEq(0, result, "Connect or bind failed.");
- if (result == 0) {
- var onSetKeepAlive = function(result) {
- if (protocol == "tcp")
- chrome.test.assertTrue(result, "setKeepAlive failed for TCP.");
- else
- chrome.test.assertFalse(result, "setKeepAlive did not fail for UDP.");
-
- string2ArrayBuffer(request, function(arrayBuffer) {
- if (protocol == "tcp")
- socket.write(socketId, arrayBuffer, onWriteOrSendToComplete);
- else
- socket.sendTo(socketId, arrayBuffer, address, port,
- onWriteOrSendToComplete);
- });
- };
-
- var onSetNoDelay = function(result) {
+function onSetKeepAlive(result) {
+ if (protocol == "tcp")
+ chrome.test.assertTrue(result, "setKeepAlive failed for TCP.");
+ else
+ chrome.test.assertFalse(result, "setKeepAlive did not fail for UDP.");
+
+ string2ArrayBuffer(request, function(arrayBuffer) {
if (protocol == "tcp")
- chrome.test.assertTrue(result, "setNoDelay failed for TCP.");
+ socket.write(socketId, arrayBuffer, onWriteOrSendToComplete);
else
- chrome.test.assertFalse(result, "setNoDelay did not fail for UDP.");
- socket.setKeepAlive(socketId, true, 1000, onSetKeepAlive);
- };
+ socket.sendTo(socketId, arrayBuffer, address, port,
+ onWriteOrSendToComplete);
+ });
+}
+function onSetNoDelay(result) {
+ if (protocol == "tcp")
+ chrome.test.assertTrue(result, "setNoDelay failed for TCP.");
+ else
+ chrome.test.assertFalse(result, "setNoDelay did not fail for UDP.");
+ socket.setKeepAlive(socketId, true, 1000, onSetKeepAlive);
+}
+
+function onConnectOrBindComplete(result) {
+ chrome.test.assertEq(0, result,
+ "Connect or bind failed with error " + result);
+ if (result == 0) {
socket.setNoDelay(socketId, true, onSetNoDelay);
}
}

Powered by Google App Engine
This is Rietveld 408576698