Allow hostnames in socket.connect().

chrome/test/data/extensions/api_test/socket/api/background.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // net/tools/testserver/testserver.py is picky about the format of what it
 // calls its "echo" messages. One might go so far as to mutter to oneself that
 // it isn't an echo server at all.
 //
 // The response is based on the request but obfuscated using a random key.
 const request = "0100000005320000005hello";
@@ skipping 63 matching lines @@
 function onWriteOrSendToComplete(writeInfo) {
   bytesWritten += writeInfo.bytesWritten;
   if (bytesWritten == request.length) {
     if (protocol == "tcp")
       socket.read(socketId, onDataRead);
     else
       socket.recvFrom(socketId, onDataRead);
   }
 }
 
+function onSetKeepAlive(result) {
+  if (protocol == "tcp")
+    chrome.test.assertTrue(result, "setKeepAlive failed for TCP.");
+  else
+    chrome.test.assertFalse(result, "setKeepAlive did not fail for UDP.");
+
+  string2ArrayBuffer(request, function(arrayBuffer) {
+      if (protocol == "tcp")
+        socket.write(socketId, arrayBuffer, onWriteOrSendToComplete);
+      else
+        socket.sendTo(socketId, arrayBuffer, address, port,
+                      onWriteOrSendToComplete);
+    });
+}
+
+function onSetNoDelay(result) {
+  if (protocol == "tcp")
+    chrome.test.assertTrue(result, "setNoDelay failed for TCP.");
+  else
+    chrome.test.assertFalse(result, "setNoDelay did not fail for UDP.");
+  socket.setKeepAlive(socketId, true, 1000, onSetKeepAlive);
+}
+
 function onConnectOrBindComplete(result) {
-  chrome.test.assertEq(0, result, "Connect or bind failed.");
+  chrome.test.assertEq(0, result,
+                       "Connect or bind failed with error " + result);
   if (result == 0) {
-    var onSetKeepAlive = function(result) {
-      if (protocol == "tcp")
-        chrome.test.assertTrue(result, "setKeepAlive failed for TCP.");
-      else
-        chrome.test.assertFalse(result, "setKeepAlive did not fail for UDP.");
-
-      string2ArrayBuffer(request, function(arrayBuffer) {
-          if (protocol == "tcp")
-            socket.write(socketId, arrayBuffer, onWriteOrSendToComplete);
-          else
-            socket.sendTo(socketId, arrayBuffer, address, port,
-                onWriteOrSendToComplete);
-        });
-    };
-
-    var onSetNoDelay = function(result) {
-      if (protocol == "tcp")
-        chrome.test.assertTrue(result, "setNoDelay failed for TCP.");
-      else
-        chrome.test.assertFalse(result, "setNoDelay did not fail for UDP.");
-      socket.setKeepAlive(socketId, true, 1000, onSetKeepAlive);
-    };
-
     socket.setNoDelay(socketId, true, onSetNoDelay);
   }
 }
 
 function onCreate(socketInfo) {
   socketId = socketInfo.socketId;
   chrome.test.assertTrue(socketId > 0, "failed to create socket");
   if (protocol == "tcp")
     socket.connect(socketId, address, port, onConnectOrBindComplete);
   else
@@ skipping 25 matching lines @@
   address = parts[1];
   port = parseInt(parts[2]);
   console.log("Running tests, protocol " + protocol + ", echo server " +
               address + ":" + port);
   chrome.test.runTests([ testSocketCreation, testSending ]);
 };
 
 // Find out which protocol we're supposed to test, and which echo server we
 // should be using, then kick off the tests.
 chrome.test.sendMessage("info_please", onMessageReply);