Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: webkit/fileapi/isolated_context_unittest.cc

Issue 10536200: Manage IsolatedContext with reference counts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/isolated_context_unittest.cc
diff --git a/webkit/fileapi/isolated_context_unittest.cc b/webkit/fileapi/isolated_context_unittest.cc
index a1b138b691f5cc60e130afe3285fde6f826aeec6..681f13665cb3b3edb786a5753c04175d21a1edc3 100644
--- a/webkit/fileapi/isolated_context_unittest.cc
+++ b/webkit/fileapi/isolated_context_unittest.cc
@@ -46,7 +46,7 @@ class IsolatedContextTest : public testing::Test {
}
void TearDown() {
- IsolatedContext::GetInstance()->RevokeIsolatedFileSystem(id_);
+ IsolatedContext::GetInstance()->RemoveReference(id_);
}
IsolatedContext* isolated_context() const {
@@ -88,7 +88,7 @@ TEST_F(IsolatedContextTest, RegisterAndRevokeTest) {
}
// Revoking the current one and registering a new (empty) one.
- isolated_context()->RevokeIsolatedFileSystem(id_);
+ isolated_context()->RemoveReference(id_);
std::string id2 = isolated_context()->RegisterIsolatedFileSystem(
std::set<FilePath>());
@@ -96,7 +96,7 @@ TEST_F(IsolatedContextTest, RegisterAndRevokeTest) {
ASSERT_TRUE(isolated_context()->GetTopLevelPaths(id2, &toplevels));
ASSERT_FALSE(isolated_context()->GetTopLevelPaths(id_, &toplevels));
- isolated_context()->RevokeIsolatedFileSystem(id2);
+ isolated_context()->RemoveReference(id2);
}
TEST_F(IsolatedContextTest, CrackWithRelativePaths) {
@@ -179,7 +179,7 @@ TEST_F(IsolatedContextTest, Writable) {
// Set writable again, and revoke the filesystem.
ASSERT_TRUE(isolated_context()->SetWritable(id_, true));
- isolated_context()->RevokeIsolatedFileSystem(id_);
+ isolated_context()->RemoveReference(id_);
// IsWritable should return false for non-registered file system.
ASSERT_FALSE(isolated_context()->IsWritable(id_));

Powered by Google App Engine
This is Rietveld 408576698