Fuse comparisons that are used by branches together.

runtime/vm/flow_graph_compiler_ia32.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_FLOW_GRAPH_COMPILER_IA32_H_
 #define VM_FLOW_GRAPH_COMPILER_IA32_H_
 
 #ifndef VM_FLOW_GRAPH_COMPILER_H_
 #error Include flow_graph_compiler.h instead of flow_graph_compiler_ia32.h.
 #endif
@@ skipping 158 matching lines @@
                       Register reg3 = kNoRegister);
 
   void FinalizeExceptionHandlers(const Code& code);
   void FinalizePcDescriptors(const Code& code);
   void FinalizeStackmaps(const Code& code);
   void FinalizeVarDescriptors(const Code& code);
   void FinalizeComments(const Code& code);
 
   static const int kLocalsOffsetFromFP = (-1 * kWordSize);
 
+  const Bool& true_value() const { return true_value_; }
+  const Bool& false_value() const { return false_value_; }
+
  private:
   friend class DeoptimizationStub;
 
   void GenerateDeferredCode();
 
   void CopyParameters();
   virtual void EmitInstructionPrologue(Instruction* instr);
 
   virtual void GenerateInlinedGetter(intptr_t offset);
   virtual void GenerateInlinedSetter(intptr_t offset);
@@ skipping 67 matching lines @@
   // for convenience.  This is not the block's index in the block order,
   // which is reverse postorder.
   BlockEntryInstr* current_block_;
   ExceptionHandlerList* exception_handlers_list_;
   DescriptorList* pc_descriptors_list_;
   StackmapBuilder* stackmap_builder_;
   GrowableArray<BlockInfo*> block_info_;
   GrowableArray<DeoptimizationStub*> deopt_stubs_;
   const bool is_optimizing_;
 
+  const Bool& true_value_;
+  const Bool& false_value_;

[srdjan, 2012/06/13 15:29:35]

I find the name 'true_value' ambiguous as it does no specify what bool value it
is (C, Dart, some enum). Better name are, IMO, true_object, bool_true,
true_handle. The C++ code uses Bool::True() to get the RawObject.

[Vyacheslav Egorov (Google), 2012/06/13 16:23:43]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(FlowGraphCompiler);
 };
 
 
 class DeoptimizationStub : public ZoneAllocated {
  public:
   DeoptimizationStub(intptr_t deopt_id,
                      intptr_t deopt_token_index,
                      intptr_t try_index,
                      DeoptReasonId reason)
@@ skipping 18 matching lines @@
   GrowableArray<Register> registers_;
   Label entry_label_;
 
   DISALLOW_COPY_AND_ASSIGN(DeoptimizationStub);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_FLOW_GRAPH_COMPILER_IA32_H_