Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 10536141: Add SpellingServiceClient::IsAvailable(). (Closed)

Created:
8 years, 6 months ago by Hironori Bono
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add SpellingServiceClient::IsAvailable(). This change adds a static function SpellingServiceClient::IsAvailable() and use it instead of checking conditions directly. BUG=none TEST=SpellingServiceClientTest.AvailableServices Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142102

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -7 lines) Patch
M chrome/browser/spellchecker/spelling_service_client.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client.cc View 1 2 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 1 3 chunks +54 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer.cc View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hironori Bono
Greetings Avi and Morita-san, Thanks for your help in advance. Would it be possible to ...
8 years, 6 months ago (2012-06-13 11:01:38 UTC) #1
Avi (use Gerrit)
lgtm http://codereview.chromium.org/10536141/diff/5/chrome/browser/spellchecker/spelling_service_client.h File chrome/browser/spellchecker/spelling_service_client.h (right): http://codereview.chromium.org/10536141/diff/5/chrome/browser/spellchecker/spelling_service_client.h#newcode92 chrome/browser/spellchecker/spelling_service_client.h:92: // Returns whether the specified service is avilable ...
8 years, 6 months ago (2012-06-13 14:46:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/10536141/13002
8 years, 6 months ago (2012-06-14 03:27:59 UTC) #3
Hironori Bono
Greetings Avi, Many thanks for your quick review. :) Regards, Hironori Bono http://codereview.chromium.org/10536141/diff/5/chrome/browser/spellchecker/spelling_service_client.h File chrome/browser/spellchecker/spelling_service_client.h ...
8 years, 6 months ago (2012-06-14 03:28:38 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-14 05:38:12 UTC) #5
Change committed as 142102

Powered by Google App Engine
This is Rietveld 408576698