Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: webkit/support/webkit_support.cc

Issue 10536140: Make GetWebKitRootDirFilePath return correct dir on Android. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/single_test_runner.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/support/webkit_support.cc
diff --git a/webkit/support/webkit_support.cc b/webkit/support/webkit_support.cc
index ff3fd4025bc3e2afd2b9ef2d904fb2c0b2720094..252ac84f06d71ede73f2ff0d69b9561845488a5b 100644
--- a/webkit/support/webkit_support.cc
+++ b/webkit/support/webkit_support.cc
@@ -221,6 +221,10 @@ class WebPluginImplWithPageDelegate
FilePath GetWebKitRootDirFilePath() {
FilePath basePath;
PathService::Get(base::DIR_SOURCE_ROOT, &basePath);
+#if defined(OS_ANDROID)
+ // Local files are at file:///data/local/tmp/third_party/WebKit/ on Android.
+ return basePath.Append(FILE_PATH_LITERAL("third_party/WebKit"));
+#else
tkent 2012/06/14 04:23:39 How about simply changing the following line like.
Hao Zheng 2012/06/18 04:34:04 Good idea. Done. On 2012/06/14 04:23:39, Kent Tamu
if (file_util::PathExists(basePath.Append(FILE_PATH_LITERAL("chrome")))) {
// We're in a WebKit-in-chrome checkout.
return basePath.Append(FILE_PATH_LITERAL("third_party/WebKit"));
@@ -236,6 +240,7 @@ FilePath GetWebKitRootDirFilePath() {
// We're in a WebKit-only, make-build, so the DIR_SOURCE_ROOT is already the
// WebKit root. That, or we have no idea where we are.
return basePath;
+#endif
}
class WebKitClientMessageLoopImpl
« no previous file with comments | « build/android/single_test_runner.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698