chrome/common/extensions/manifest_tests/extension_manifest_test.cc - Issue 10536084: Add a warning when developing an extension that uses old manifest version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifest_test.cc

Issue 10536084: Add a warning when developing an extension that uses old manifest version. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: blonk Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifest_test.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifest_test.cc b/chrome/common/extensions/manifest_tests/extension_manifest_test.cc

index d9619777ab8a32ad4981a69d77aeb5f515dfdc3b..a245cf80dfb2a2dda5652a8f68bb7efa4a8c61c8 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifest_test.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifest_test.cc

@@ -127,7 +127,7 @@ scoped_refptr<Extension> ExtensionManifestTest::LoadAndExpectWarning(

EXPECT_TRUE(extension) << manifest.name();

EXPECT_EQ("", error) << manifest.name();

EXPECT_EQ(1u, extension->install_warnings().size());

- EXPECT_EQ(expected_warning, extension->install_warnings()[0]);

+ EXPECT_EQ(expected_warning, extension->install_warnings()[0].message);

return extension;

}