chrome/common/extensions/extension_unittest.cc - Issue 10536084: Add a warning when developing an extension that uses old manifest version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_unittest.cc

Issue 10536084: Add a warning when developing an extension that uses old manifest version. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: blonk Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/extension_unittest.cc

diff --git a/chrome/common/extensions/extension_unittest.cc b/chrome/common/extensions/extension_unittest.cc

index 4c5f57a5ea7307dc9d661a69a931a01dcf1494f3..26e283f962837f7e23acb414a7fe93fc26cc279a 100644

--- a/chrome/common/extensions/extension_unittest.cc

+++ b/chrome/common/extensions/extension_unittest.cc

@@ -189,7 +189,7 @@ TEST(ExtensionTest, GetAbsolutePathNoError) {

"absolute.json");

EXPECT_TRUE(extension.get());

std::string err;

- std::vector<std::string> warnings;

+ Extension::InstallWarningVector warnings;

EXPECT_TRUE(extension_file_util::ValidateExtension(extension.get(),

&err, &warnings));

EXPECT_EQ(0U, warnings.size());

« no previous file with comments | « chrome/common/extensions/extension_file_util_unittest.cc ('k') | chrome/common/extensions/extension_unpacker.cc » ('j') | no next file with comments »