Add a warning when developing an extension that uses old manifest version.

chrome/common/extensions/manifest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/manifest.h"
 
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/string_split.h"
@@ skipping 26 matching lines @@
     }
   } else {
     type_ = Extension::TYPE_EXTENSION;
   }
   CHECK_NE(type_, Extension::TYPE_UNKNOWN);
 }
 
 Manifest::~Manifest() {
 }
 
-void Manifest::ValidateManifest(std::string* error,
-                                std::vector<std::string>* warnings) const {
+void Manifest::ValidateManifest(
+    std::string* error,
+    Extension::InstallWarningVector* warnings) const {
   *error = "";
   if (type_ == Extension::TYPE_PLATFORM_APP && GetManifestVersion() < 2) {
     *error = errors::kPlatformAppNeedsManifestVersion2;
     return;
   }
 
   // Check every feature to see if its in the manifest. Note that this means
   // we will ignore keys that are not features; we do this for forward
   // compatibility.
   // TODO(aa): Consider having an error here in the case of strict error
   // checking to let developers know when they screw up.
 
   std::set<std::string> feature_names =
       SimpleFeatureProvider::GetManifestFeatures()->GetAllFeatureNames();
   for (std::set<std::string>::iterator feature_name = feature_names.begin();
        feature_name != feature_names.end(); ++feature_name) {
     // Use Get instead of HasKey because the former uses path expansion.
     if (!value_->Get(*feature_name, NULL))
       continue;
 
     Feature* feature =
         SimpleFeatureProvider::GetManifestFeatures()->GetFeature(*feature_name);
     Feature::Availability result = feature->IsAvailableToManifest(
         extension_id_, type_, Feature::ConvertLocation(location_),
         GetManifestVersion());
     if (result != Feature::IS_AVAILABLE)
-      warnings->push_back(feature->GetErrorMessage(result));
+      warnings->push_back(Extension::InstallWarning(
+          Extension::InstallWarning::FORMAT_TEXT,
+          feature->GetErrorMessage(result)));
   }
 
   // Also generate warnings for keys that are not features.
   for (DictionaryValue::key_iterator key = value_->begin_keys();
       key != value_->end_keys(); ++key) {
     if (!SimpleFeatureProvider::GetManifestFeatures()->GetFeature(*key)) {
-      warnings->push_back(base::StringPrintf("Unrecognized manifest key '%s'.",
-          (*key).c_str()));
+      warnings->push_back(Extension::InstallWarning(
+          Extension::InstallWarning::FORMAT_TEXT,
+          base::StringPrintf("Unrecognized manifest key '%s'.",
+                             (*key).c_str())));
     }
   }
 }
 
 bool Manifest::HasKey(const std::string& key) const {
   return CanAccessKey(key) && value_->HasKey(key);
 }
 
 bool Manifest::HasPath(const std::string& path) const {
   Value* ignored = NULL;
@@ skipping 70 matching lines @@
       SimpleFeatureProvider::GetManifestFeatures()->GetFeature(key);
   if (!feature)
     return true;
 
   return Feature::IS_AVAILABLE == feature->IsAvailableToManifest(
       extension_id_, type_, Feature::ConvertLocation(location_),
       GetManifestVersion());
 }
 
 }  // namespace extensions