Add a warning when developing an extension that uses old manifest version.

chrome/common/extensions/extension_unpacker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_unpacker.h"
 
 #include <set>
 
 #include "base/file_util.h"
 #include "base/json/json_file_value_serializer.h"
@@ skipping 12 matching lines @@
 #include "content/public/common/common_param_traits.h"
 #include "ipc/ipc_message_utils.h"
 #include "net/base/file_stream.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "webkit/glue/image_decoder.h"
 
 namespace errors = extension_manifest_errors;
 namespace keys = extension_manifest_keys;
 namespace filenames = extension_filenames;
 
+using extensions::Extension;
+
 namespace {
 
 // Errors
 const char* kCouldNotCreateDirectoryError =
     "Could not create directory for unzipping: ";
 const char* kCouldNotDecodeImageError = "Could not decode theme image.";
 const char* kCouldNotUnzipExtension = "Could not unzip extension.";
 const char* kPathNamesMustBeAbsoluteOrLocalError =
     "Path names must not be absolute or contain '..'.";
 
@@ skipping 36 matching lines @@
     }
   }
 
   return false;
 }
 
 }  // namespace
 
 ExtensionUnpacker::ExtensionUnpacker(const FilePath& extension_path,
                                      const std::string& extension_id,
-                                     extensions::Extension::Location location,
+                                     Extension::Location location,
                                      int creation_flags)
     : extension_path_(extension_path),
       extension_id_(extension_id),
       location_(location),
       creation_flags_(creation_flags) {
 }
 
 ExtensionUnpacker::~ExtensionUnpacker() {
 }
 
 DictionaryValue* ExtensionUnpacker::ReadManifest() {
   FilePath manifest_path =
-      temp_install_dir_.Append(extensions::Extension::kManifestFilename);
+      temp_install_dir_.Append(Extension::kManifestFilename);
   if (!file_util::PathExists(manifest_path)) {
     SetError(errors::kInvalidManifest);
     return NULL;
   }
 
   JSONFileValueSerializer serializer(manifest_path);
   std::string error;
   scoped_ptr<Value> root(serializer.Deserialize(NULL, &error));
   if (!root.get()) {
     SetError(error);
     return NULL;
   }
 
   if (!root->IsType(Value::TYPE_DICTIONARY)) {
     SetError(errors::kInvalidManifest);
     return NULL;
   }
 
   return static_cast<DictionaryValue*>(root.release());
 }
 
 bool ExtensionUnpacker::ReadAllMessageCatalogs(
     const std::string& default_locale) {
   FilePath locales_path =
-    temp_install_dir_.Append(extensions::Extension::kLocaleFolder);
+    temp_install_dir_.Append(Extension::kLocaleFolder);
 
   // Not all folders under _locales have to be valid locales.
   file_util::FileEnumerator locales(locales_path,
                                     false,
                                     file_util::FileEnumerator::DIRECTORIES);
 
   std::set<std::string> all_locales;
   extension_l10n_util::GetAllLocales(&all_locales);
   FilePath locale_path;
   while (!(locale_path = locales.Next()).empty()) {
     if (extension_l10n_util::ShouldSkipValidation(locales_path, locale_path,
                                                   all_locales))
       continue;
 
     FilePath messages_path =
-      locale_path.Append(extensions::Extension::kMessagesFilename);
+      locale_path.Append(Extension::kMessagesFilename);
 
     if (!ReadMessageCatalog(messages_path))
       return false;
   }
 
   return true;
 }
 
 bool ExtensionUnpacker::Run() {
   DVLOG(1) << "Installing extension " << extension_path_.value();
@@ skipping 17 matching lines @@
     SetError(kCouldNotUnzipExtension);
     return false;
   }
 
   // Parse the manifest.
   parsed_manifest_.reset(ReadManifest());
   if (!parsed_manifest_.get())
     return false;  // Error was already reported.
 
   std::string error;
-  scoped_refptr<extensions::Extension> extension(extensions::Extension::Create(
+  scoped_refptr<Extension> extension(Extension::Create(
       temp_install_dir_,
       location_,
       *parsed_manifest_,
       creation_flags_,
       extension_id_,
       &error));
   if (!extension.get()) {
     SetError(error);
     return false;
   }
 
-  std::vector<std::string> warnings;
+  Extension::InstallWarningVector warnings;
   if (!extension_file_util::ValidateExtension(extension.get(),
                                               &error, &warnings)) {
     SetError(error);
     return false;
   }
   extension->AddInstallWarnings(warnings);
 
   // Decode any images that the browser needs to display.
   std::set<FilePath> image_paths = extension->GetBrowserImages();
   for (std::set<FilePath>::iterator it = image_paths.begin();
@@ skipping 118 matching lines @@
     return false;
   }
   parsed_catalogs_->Set(dir_name, root.release());
 
   return true;
 }
 
 void ExtensionUnpacker::SetError(const std::string &error) {
   error_message_ = UTF8ToUTF16(error);
 }