Add a warning when developing an extension that uses old manifest version.

chrome/common/extensions/extension_file_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_file_util.h"
 
 #include "base/file_util.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
@@ skipping 365 matching lines @@
   std::string kManifest =
       base::StringPrintf(
           "{ \"name\": \"Test\", \"version\": \"1.0\", "
           "  \"theme\": { \"images\": { \"theme_frame\": \"%s\" } }"
           "}", non_ascii_file.c_str());
   std::string error;
   scoped_refptr<Extension> extension = LoadExtensionManifest(
       kManifest, temp.path(), Extension::LOAD, 0, &error);
   ASSERT_TRUE(extension.get()) << error;
 
-  std::vector<std::string> warnings;
+  Extension::InstallWarningVector warnings;
   EXPECT_TRUE(extension_file_util::ValidateExtension(extension,
                                                      &error, &warnings)) <<
       error;
   EXPECT_EQ(0U, warnings.size());
 }
 
 #if defined(OS_WIN)
 // This test hangs on Windows sometimes. http://crbug.com/110279
 #define MAYBE_BackgroundScriptsMustExist DISABLED_BackgroundScriptsMustExist
 #else
 #define MAYBE_BackgroundScriptsMustExist BackgroundScriptsMustExist
 #endif
 TEST(ExtensionFileUtil, MAYBE_BackgroundScriptsMustExist) {
   ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
   scoped_ptr<DictionaryValue> value(new DictionaryValue());
   value->SetString("name", "test");
   value->SetString("version", "1");
   value->SetInteger("manifest_version", 1);
 
   ListValue* scripts = new ListValue();
   scripts->Append(Value::CreateStringValue("foo.js"));
   value->Set("background.scripts", scripts);
 
   std::string error;
-  std::vector<std::string> warnings;
+  Extension::InstallWarningVector warnings;
   scoped_refptr<Extension> extension = LoadExtensionManifest(
       value.get(), temp.path(), Extension::LOAD, 0, &error);
   ASSERT_TRUE(extension.get()) << error;
 
   EXPECT_FALSE(extension_file_util::ValidateExtension(extension,
                                                       &error, &warnings));
   EXPECT_EQ(l10n_util::GetStringFUTF8(
       IDS_EXTENSION_LOAD_BACKGROUND_SCRIPT_FAILED, ASCIIToUTF16("foo.js")),
            error);
   EXPECT_EQ(0U, warnings.size());
@@ skipping 78 matching lines @@
   ASSERT_TRUE(file_util::WriteFile(ext_path.AppendASCII("manifest.json"),
                                    manifest, strlen(manifest)));
   ASSERT_TRUE(file_util::WriteFile(ext_path.AppendASCII("a_key.pem"),
                                    private_key, strlen(private_key)));
 
   std::string error;
   scoped_refptr<Extension> extension(extension_file_util::LoadExtension(
       ext_path, "the_id", Extension::EXTERNAL_PREF,
       Extension::NO_FLAGS, &error));
   ASSERT_TRUE(extension.get()) << error;
-  EXPECT_THAT(extension->install_warnings(),
-              testing::ElementsAre(
-                  testing::ContainsRegex(
-                      "extension includes the key file.*ext_root.a_key.pem")));
+  ASSERT_EQ(1u, extension->install_warnings().size());
+  EXPECT_THAT(
+      extension->install_warnings(),
+      testing::ElementsAre(
+          testing::Field(
+              &Extension::InstallWarning::message,
+              testing::ContainsRegex(
+                  "extension includes the key file.*ext_root.a_key.pem"))));
 
   // Turn the warning into an error with ERROR_ON_PRIVATE_KEY.
   extension = extension_file_util::LoadExtension(
       ext_path, "the_id", Extension::EXTERNAL_PREF,
       Extension::ERROR_ON_PRIVATE_KEY, &error);
   EXPECT_FALSE(extension.get());
   EXPECT_THAT(error,
               testing::ContainsRegex(
                   "extension includes the key file.*ext_root.a_key.pem"));
 }
 
 // TODO(aa): More tests as motivation allows. Maybe steal some from
 // ExtensionService? Many of them could probably be tested here without the
 // MessageLoop shenanigans.