Add a warning when developing an extension that uses old manifest version.

chrome/common/extensions/extension.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #pragma once
 
 #include <algorithm>
 #include <map>
@@ skipping 37 matching lines @@
 
 FORWARD_DECLARE_TEST(TabStripModelTest, Apps);
 
 namespace extensions {
 
 class Manifest;
 
 // Represents a Chrome extension.
 class Extension : public base::RefCountedThreadSafe<Extension> {
  public:
+  struct InstallWarning;
+
   typedef std::map<const std::string, GURL> URLOverrideMap;
   typedef std::vector<std::string> ScriptingWhitelist;
   typedef std::vector<linked_ptr<FileBrowserHandler> > FileBrowserHandlerList;
+  typedef std::vector<InstallWarning> InstallWarningVector;
 
   // What an extension was loaded from.
   // NOTE: These values are stored as integers in the preferences and used
   // in histograms so don't remove or reorder existing items.  Just append
   // to the end.
   enum Location {
     INVALID,
     INTERNAL,           // A crx file from the internal Extensions directory.
     EXTERNAL_PREF,      // A crx file from an external directory (via prefs).
     EXTERNAL_REGISTRY,  // A crx file from an external directory (via eg the
@@ skipping 104 matching lines @@
   struct OAuth2Info {
     OAuth2Info();
     ~OAuth2Info();
 
     ExtensionOAuth2Scopes GetScopesAsSet();
 
     std::string client_id;
     std::vector<std::string> scopes;
   };
 
+  struct InstallWarning {
+    enum Format {
+      // IMPORTANT: Do not build HTML strings from user or developer-supplied
+      // input.
+      FORMAT_TEXT,
+      FORMAT_HTML,
+    };
+    InstallWarning(Format format, const std::string& message)
+        : format(format), message(message) {
+    }
+    Format format;
+    std::string message;
+  };
+
   enum InitFromValueFlags {
     NO_FLAGS = 0,
 
     // Usually, the id of an extension is generated by the "key" property of
     // its manifest, but if |REQUIRE_KEY| is not set, a temporary ID will be
     // generated based on the path.
     REQUIRE_KEY = 1 << 0,
 
     // Requires the extension to have an up-to-date manifest version.
     // Typically, we'll support multiple manifest versions during a version
@@ skipping 409 matching lines @@
   }
   const GURL& options_url() const { return options_url_; }
   const GURL& devtools_url() const { return devtools_url_; }
   const ExtensionPermissionSet* optional_permission_set() const {
     return optional_permission_set_.get();
   }
   const ExtensionPermissionSet* required_permission_set() const {
     return required_permission_set_.get();
   }
   // Appends |new_warnings| to install_warnings().
-  void AddInstallWarnings(const std::vector<std::string>& new_warnings);
-  const std::vector<std::string>& install_warnings() const {
+  void AddInstallWarnings(const InstallWarningVector& new_warnings);
+  const InstallWarningVector& install_warnings() const {
     return install_warnings_;
   }
   const GURL& update_url() const { return update_url_; }
   const ExtensionIconSet& icons() const { return icons_; }
   const extensions::Manifest* manifest() const {
     return manifest_;
   }
   const std::string default_locale() const { return default_locale_; }
   const URLOverrideMap& GetChromeURLOverrides() const {
     return chrome_url_overrides_;
@@ skipping 270 matching lines @@
   mutable base::Lock runtime_data_lock_;
   mutable RuntimeData runtime_data_;
 
   // The set of permissions the extension can request at runtime.
   scoped_refptr<const ExtensionPermissionSet> optional_permission_set_;
 
   // The extension's required / default set of permissions.
   scoped_refptr<const ExtensionPermissionSet> required_permission_set_;
 
   // Any warnings that occurred when trying to create/parse the extension.
-  std::vector<std::string> install_warnings_;
+  InstallWarningVector install_warnings_;
 
   // The icons for the extension.
   ExtensionIconSet icons_;
 
   // The base extension url for the extension.
   GURL extension_url_;
 
   // The extension's version.
   scoped_ptr<Version> version_;
 
@@ skipping 219 matching lines @@
 
   UpdatedExtensionPermissionsInfo(
       const Extension* extension,
       const ExtensionPermissionSet* permissions,
       Reason reason);
 };
 
 } // namespace extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_H_