Plumb rendering statistics to benchmarking extension.

chrome/renderer/benchmarking_extension.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/benchmarking_extension.h"
 
 #include "base/command_line.h"
 #include "base/metrics/stats_table.h"
 #include "base/time.h"
 #include "chrome/common/benchmarking_messages.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/renderer/render_thread.h"
+#include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebCache.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
+#include "third_party/WebKit/Source/Platform/chromium/public/WebRenderingStats.h"
 #include "v8/include/v8.h"
 
 using WebKit::WebCache;
+using WebKit::WebFrame;
+using WebKit::WebView;
+using WebKit::WebRenderingStats;
 
 const char kBenchmarkingExtensionName[] = "v8/Benchmarking";
 
 namespace extensions_v8 {
 
 class BenchmarkingWrapper : public v8::Extension {
  public:
   BenchmarkingWrapper() :
       v8::Extension(kBenchmarkingExtensionName,
         "if (typeof(chrome) == 'undefined') {"
@@ skipping 23 matching lines @@
         "  return GetCounter(name);"
         "};"
         "chrome.benchmarking.enableSpdy = function(name) {"
         "  native function EnableSpdy();"
         "  EnableSpdy(name);"
         "};"
         "chrome.benchmarking.isSingleProcess = function() {"
         "  native function IsSingleProcess();"
         "  return IsSingleProcess();"
         "};"
+        "chrome.benchmarking.renderingStats = function() {"
+        "  native function RenderingStats();"

[nduca, 2012/06/15 00:26:22]

We want to move these changes to gpu_benchmarking_extension

[dtu, 2012/06/20 00:57:32]

Done.

+        "  return RenderingStats();"
+        "};"
         "chrome.Interval = function() {"
         "  var start_ = 0;"
         "  var stop_ = 0;"
         "  native function HiResTime();"
         "  this.start = function() {"
         "    stop_ = 0;"
         "    start_ = HiResTime();"
         "  };"
         "  this.stop = function() {"
         "    stop_ = HiResTime();"
@@ skipping 18 matching lines @@
     } else if (name->Equals(v8::String::New("ClearHostResolverCache"))) {
       return v8::FunctionTemplate::New(ClearHostResolverCache);
     } else if (name->Equals(v8::String::New("ClearPredictorCache"))) {
       return v8::FunctionTemplate::New(ClearPredictorCache);
     } else if (name->Equals(v8::String::New("EnableSpdy"))) {
       return v8::FunctionTemplate::New(EnableSpdy);
     } else if (name->Equals(v8::String::New("GetCounter"))) {
       return v8::FunctionTemplate::New(GetCounter);
     } else if (name->Equals(v8::String::New("IsSingleProcess"))) {
       return v8::FunctionTemplate::New(IsSingleProcess);
+    } else if (name->Equals(v8::String::New("RenderingStats"))) {
+      return v8::FunctionTemplate::New(RenderingStats);
     } else if (name->Equals(v8::String::New("HiResTime"))) {
       return v8::FunctionTemplate::New(HiResTime);
     }
 
     return v8::Handle<v8::FunctionTemplate>();
   }
 
   static v8::Handle<v8::Value> CloseConnections(const v8::Arguments& args) {
     content::RenderThread::Get()->Send(
         new ChromeViewHostMsg_CloseCurrentConnections());
@@ skipping 48 matching lines @@
 
     int counter = base::StatsTable::current()->GetCounterValue(name);
     return v8::Integer::New(counter);
   }
 
   static v8::Handle<v8::Value> IsSingleProcess(const v8::Arguments& args) {
     return v8::Boolean::New(
        CommandLine::ForCurrentProcess()->HasSwitch(switches::kSingleProcess));
   }
 
+  static v8::Handle<v8::Value> RenderingStats(const v8::Arguments& args) {
+    WebFrame* web_frame = WebFrame::frameForEnteredContext();
+    if (!web_frame)
+      return v8::Undefined();
+
+    WebView* web_view = web_frame->view();
+    if (!web_view)
+      return v8::Undefined();
+
+    content::RenderView* render_view =
+        content::RenderView::FromWebView(web_view);
+    if (!render_view)
+      return v8::Undefined();
+
+    WebRenderingStats stats;
+    render_view->GetRenderingStats(stats);
+

[nduca, 2012/06/15 00:26:22]

/me wonders if there's a way to get the fields of this struct into a v8 object
without having  to edit chrome. Any ideas? Maybe james or nate chapin (@japhet)
have some ideas... i think it would be nice to be able to add metrics without
having to make an edit to chrome each time we do it.

+    v8::Handle<v8::Object> stats_object = v8::Object::New();
+    if (stats.frameNumber)
+      stats_object->Set(v8::String::New("frameNumber"),
+                        v8::Integer::New(stats.frameNumber), v8::ReadOnly);
+    if (stats.implFrameNumber)
+      stats_object->Set(v8::String::New("implFrameNumber"),
+                        v8::Integer::New(stats.implFrameNumber), v8::ReadOnly);
+    return stats_object;
+  }
+
   static v8::Handle<v8::Value> HiResTime(const v8::Arguments& args) {
     return v8::Number::New(
         static_cast<double>(base::TimeTicks::HighResNow().ToInternalValue()));
   }
 };
 
 v8::Extension* BenchmarkingExtension::Get() {
   return new BenchmarkingWrapper();
 }
 
 }  // namespace extensions_v8