Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 10536079: Fix to ensure that external resources are treated as read-only. (Closed)

Created:
8 years, 6 months ago by pquitslund
Modified:
8 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix to ensure that external resources are treated as read-only. This is an old chesnut. See: dartbug.com/3429 for some recent context, motivation and user woes. Committed: https://code.google.com/p/dart/source/detail?r=8474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/ExternalCompilationUnitEditorInput.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
8 years, 6 months ago (2012-06-08 22:08:55 UTC) #1
Brian Wilkerson
LGTM
8 years, 6 months ago (2012-06-08 22:10:04 UTC) #2
danrubel
8 years, 6 months ago (2012-06-08 23:45:18 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698