Generate code for store buffer updates in open-coded object field stores.

runtime/vm/assembler_ia32.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ASSEMBLER_IA32_H_
 #define VM_ASSEMBLER_IA32_H_
 
 #ifndef VM_ASSEMBLER_H_
 #error Do not include assembler_ia32.h directly; use assembler.h instead.
 #endif
@@ skipping 503 matching lines @@
 
   void LoadObject(Register dst, const Object& object);
   void PushObject(const Object& object);
   void CompareObject(Register reg, const Object& object);
   void LoadDoubleConstant(XmmRegister dst, double value);
 
   void StoreIntoObject(Register object,  // Object we are storing into.
                        const FieldAddress& dest,  // Where we are storing into.
                        Register value);  // Value we are storing.
 
+  void StoreIntoObjectNoBarrier(Register object,

[Ivan Posva, 2012/06/12 13:43:58]

I don't think you need the object for these two stores.

[cshapiro, 2012/06/12 21:41:01]

If you are suggesting that a minimal implementation does not need the parameter,
I do understand that.  But, there is more going on here than just a field
assignment.

The object argument is used by the implementation of this method.  This is used
to validate the safety of the store in debug mode.  Also, for this method, and
the method below, I need the object for implementing tracing of assignments to
heap objects.

+                                const FieldAddress& dest,
+                                Register value);
+  void StoreIntoObjectNoBarrier(Register object,
+                                const FieldAddress& dest,
+                                const Immediate& value);
+
   void DoubleNegate(XmmRegister d);
   void FloatNegate(XmmRegister f);
 
   void DoubleAbs(XmmRegister reg);
 
   void LockCmpxchgl(const Address& address, Register reg) {
     lock();
     cmpxchgl(address, reg);
   }
 
@@ skipping 120 matching lines @@
 }
 
 
 inline void Assembler::EmitOperandSizeOverride() {
   EmitUint8(0x66);
 }
 
 }  // namespace dart
 
 #endif  // VM_ASSEMBLER_IA32_H_