Generate code for store buffer updates in open-coded object field stores.

runtime/vm/code_generator.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler_macros.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/dart_api_impl.h"
@@ skipping 1543 matching lines @@
         }
       }
     }
   }
   // The cache is null terminated, therefore the loop above should never
   // terminate by itself.
   UNREACHABLE();
   return Code::null();
 }
 
+
+// Adds a pointer to the store buffer.
+// Arg0: pointer
+DEFINE_RUNTIME_ENTRY(StoreBuffer, 1) {

[Ivan Posva, 2012/06/08 14:39:55]

This then would be StoreBuffer_Process.

+  ASSERT(arguments.Count() == kStoreBufferRuntimeEntry.argument_count());
+  RawObject* dest = arguments.At(0);

[srdjan, 2012/06/08 05:46:59]

You may want to do Object::CheckedHandle so that you guarantee that the object
is a an object?

[cshapiro, 2012/06/08 23:48:04]

Unfortunately, I cannot.  dest is not an object, it is just a field address.

+  uword ptr = reinterpret_cast<uword>(dest);
+  Isolate::Current()->store_buffer()->AddPointer(ptr);

[siva, 2012/06/08 17:26:01]

isolate->store_buffer()....

isolate is a param to runtime entry calls and is already set up.

[cshapiro, 2012/06/08 23:48:04]

Fixed.

+}
+
 }  // namespace dart