Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2344)

Unified Diff: content/public/browser/android/content_view.h

Issue 10536066: android content shell bringup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more jam feedback Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/android/content_view.h
diff --git a/content/public/browser/android/content_view.h b/content/public/browser/android/content_view.h
new file mode 100644
index 0000000000000000000000000000000000000000..2b4e19210bba1fb1d4c3b5b6220324aecc212f34
--- /dev/null
+++ b/content/public/browser/android/content_view.h
@@ -0,0 +1,38 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_H_
+#define CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_H_
+#pragma once
+
+#include <jni.h>
+#include <vector>
+
+#include "base/android/jni_helper.h"
+#include "base/memory/weak_ptr.h"
+
+namespace content {
+class JavaScriptDialogCreator;
jam 2012/06/14 01:31:41 nit: get rid of all the includes and forward decla
jam 2012/06/14 16:11:10 looks like this isn't done yet?
John Grabowski 2012/06/14 17:56:31 Sorry... I was editing content/public/browser/cont
+}
+
+namespace content {
+// Native side of the ContentView.java, the primary FrameLayout of
+// Chromium on Android. This is a public interface used by native
+// code outside of the content module.
+//
+// TODO(jrg): this is a shell. Upstream the rest.
+class ContentView : public base::SupportsWeakPtr<ContentView> {
+ public:
+ virtual void Destroy(JNIEnv* env, jobject obj) = 0;
+
+ static ContentView* Create(JNIEnv* env, jobject obj);
+ static ContentView* GetNativeContentView(JNIEnv* env, jobject obj);
+
+ protected:
+ virtual ~ContentView() {};
+};
+
+}; // namespace content
+
+#endif // CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_H_

Powered by Google App Engine
This is Rietveld 408576698