android content shell bringup.

content/browser/android/content_view_impl.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_IMPL_H_
+#define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_IMPL_H_
+#pragma once
+
+#include <jni.h>
+#include <vector>
+
+#include "base/android/jni_helper.h"
+#include "base/memory/weak_ptr.h"

[jam, 2012/06/08 23:45:09]

nit: don't need these 4 includes since content_view.h includes them

[jam, 2012/06/12 17:44:02]

?

[John Grabowski, 2012/06/13 22:12:29]

Wouldn't IWYU mean I should keep jni_helper.h and notification_observer.h?
(weak_ptr removed)

[jam, 2012/06/14 01:31:40]

as far as i can tell, jni.h and jni_helper.h are used by the parent interface.
so there's no reason to include them in the derived interfaces.

<vector> isn't used by the parent, so it should move out of there.

notification_observer.h is fine now that it's not in the other header

+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/content_view.h"
+
+class ContentViewClient;
+
+namespace content {
+class JavaScriptDialogCreator;

[jam, 2012/06/08 23:45:09]

nit: not used

[jam, 2012/06/12 17:44:02]

?

[John Grabowski, 2012/06/13 22:12:29]

Removed

+}
+
+namespace content {
+
+// TODO(jrg): this is a shell.  Upstream the rest.
+class ContentViewImpl : public ContentView,
+                        public content::NotificationObserver {
+ public:
+  ContentViewImpl(JNIEnv* env,
+              jobject obj);

[jam, 2012/06/08 23:45:09]

nit: tabbing

[jam, 2012/06/12 17:44:02]

?

[John Grabowski, 2012/06/13 22:12:29]

fixed

+  virtual void Destroy(JNIEnv* env, jobject obj);
+
+ private:
+  // NotificationObserver implementation.
+  virtual void Observe(int type,
+                       const content::NotificationSource& source,
+                       const content::NotificationDetails& details) OVERRIDE;
+
+  // --------------------------------------------------------------------------
+  // Private methods that call to Java via JNI
+  // --------------------------------------------------------------------------
+  virtual ~ContentViewImpl();
+
+  // --------------------------------------------------------------------------
+  // Other private methods and data
+  // --------------------------------------------------------------------------
+  DISALLOW_COPY_AND_ASSIGN(ContentViewImpl);
+};
+
+};  // namespace content
+
+#endif  // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_IMPL_H_