Issue 10536003: [cros] Add comments for login WebUI related notifications.

Issue 10536003: [cros] Add comments for login WebUI related notifications. (Closed)

Created:
8 years, 6 months ago by Nikita (slow)

Modified:
8 years, 6 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros] Add comments for login WebUI related notifications. Rename _LOGIN_WEBUI_READY to _LOGIN_WEBUI_LOADED BUG=127517 TEST=N/A Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140651

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2

Patch Set 3 : rename LOGIN_WEBUI_READY > LOGIN_WEBUI_LOADED #

Patch Set 4 : rename in header #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -17 lines)			Patch
M	chrome/browser/automation/automation_provider_observers_chromeos.cc	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_notification_types.h	View	1 2 3	2 chunks	+44 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

Daniel, please take a look. I haven't renamed them, just added comments. I'm open for ...

8 years, 6 months ago (2012-06-05 08:29:21 UTC) #1

Daniel Erat

LGTM Thanks! As far as naming suggestions go, _LOGIN_WEBUI_READY might be clearer as _LOGIN_WEBUI_LOADED. The ...

8 years, 6 months ago (2012-06-05 15:38:32 UTC) #2

Nikita (slow)

http://codereview.chromium.org/10536003/diff/2001/chrome/common/chrome_notification_types.h File chrome/common/chrome_notification_types.h (right): http://codereview.chromium.org/10536003/diff/2001/chrome/common/chrome_notification_types.h#newcode926 chrome/common/chrome_notification_types.h:926: // First paint event after this screen fires NOTIFICATION_LOGIN_WEBUI_VISIBLE. ...

8 years, 6 months ago (2012-06-05 16:33:50 UTC) #3

Nikita (slow)

On 2012/06/05 15:38:32, Daniel Erat wrote: > LGTM > > Thanks! As far as naming ...

8 years, 6 months ago (2012-06-05 16:34:35 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10536003/13001

8 years, 6 months ago (2012-06-05 21:08:46 UTC) #5

Change committed as 140651

Expand Messages | Collapse Messages