remoting/protocol/audio_writer.cc - Issue 10535153: Added files for audio writers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/protocol/audio_writer.cc

Issue 10535153: Added files for audio writers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed a small style issue Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "remoting/protocol/audio_writer.h"

	6

	7 #include "remoting/protocol/protobuf_audio_writer.h"

	8 #include "remoting/protocol/session_config.h"

	9

	10 namespace remoting {

	11 namespace protocol {

	12

	13 AudioWriter::~AudioWriter() { }

	14

	15 // static

	16 AudioWriter* AudioWriter::Create(const SessionConfig& config) {

	17 // TODO(kxing) make this correct
	Sergey Ulanov 2012/06/14 17:53:17 nit: should be formatted like this: TODO(kxing): nit: should be formatted like this: TODO(kxing): Make this correct. Sergey Ulanov 2012/06/14 17:53:17 nit: comment is not clear. Should it be "Implement nit: comment is not clear. Should it be "Implement this."? Also please add NOTIMPLEMENTED() here. kxing 2012/06/14 22:30:42 Sorry, I meant for the comment to read: "Support d Sorry, I meant for the comment to read: "Support different configurations." On 2012/06/14 17:53:17, sergeyu wrote: Show quoted text > nit: comment is not clear. Should it be "Implement this."? > Also please add NOTIMPLEMENTED() here. kxing 2012/06/14 22:30:42 Done. Show quoted text On 2012/06/14 17:53:17, sergeyu wrote: > nit: should be formatted like this: > TODO(kxing): Make this correct. Done.
	18 return new ProtobufAudioWriter();

	19 }

	20

	21 } // namespace protocol

	22 } // namespace remoting

OLD	NEW