content/browser/download/download_item_impl.cc - Issue 10535135: Made ownership of DownloadRequestHandles clear through scoped_ptr<>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl.cc

Issue 10535135: Made ownership of DownloadRequestHandles clear through scoped_ptr<> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated comments. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_item_impl.cc

diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc

index 2f967a89daba0dc13f452a1b71519c087647b0f9..90dc34a837f8cac6fe78a2f48e5e2013d2fcea20 100644

--- a/content/browser/download/download_item_impl.cc

+++ b/content/browser/download/download_item_impl.cc

@@ -209,10 +209,10 @@ DownloadItemImpl::DownloadItemImpl(Delegate* delegate,

DownloadItemImpl::DownloadItemImpl(

Delegate* delegate,

const DownloadCreateInfo& info,

- DownloadRequestHandleInterface* request_handle,

+ scoped_ptr<DownloadRequestHandleInterface> request_handle,

bool is_otr,

const net::BoundNetLog& bound_net_log)

- : request_handle_(request_handle),

+ : request_handle_(request_handle.Pass()),

download_id_(info.download_id),

target_disposition_(

(info.prompt_user_for_save_location) ?