Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: remoting/host/constants.h

Issue 10535082: /C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/constants.h
diff --git a/remoting/host/constants.h b/remoting/host/constants.h
index 9654afffc708b6d9a073f46b82736dd101487ea3..9358583f1812d3aec665c3bc8d590d9a108b5251 100644
--- a/remoting/host/constants.h
+++ b/remoting/host/constants.h
@@ -5,6 +5,8 @@
#ifndef REMOTING_HOST_CONSTANTS_H_
#define REMOTING_HOST_CONSTANTS_H_
+#include "base/string16.h"
Peter Kasting 2012/06/14 20:16:27 Nit: #ifdef this as well. I suggest moving the bl
alexeypa (please no reviews) 2012/06/15 18:45:49 I got rid of string16 entirely. BTW I don't thin
Peter Kasting 2012/06/15 19:02:42 Yes, I was suggesting the opposite (to move some c
alexeypa (please no reviews) 2012/06/15 19:51:24 Well, actually your comment was quite clear. I jus
+
namespace remoting {
// Known host exit codes.
@@ -24,6 +26,13 @@ enum HostExitCodes {
kMaxPermanentErrorExitCode = kInvalidOauthCredentialsExitCode
};
+#if defined(OS_WIN)
+
Peter Kasting 2012/06/14 20:16:27 Nit: Extra blank line here and below. There aren'
alexeypa (please no reviews) 2012/06/15 18:45:49 Done.
+// The Omaha Appid of the host.
+extern const char16 kHostOmahaAppid[];
Peter Kasting 2012/06/14 20:16:27 This should be a wchar_t rather than a string16, g
alexeypa (please no reviews) 2012/06/15 18:45:49 Done.
+
+#endif // defined(OS_WIN)
+
} // namespace remoting
#endif // REMOTING_HOST_CONSTANTS_H_

Powered by Google App Engine
This is Rietveld 408576698