remoting/host/breakpad.h - Issue 10535082: /C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/breakpad.h

Issue 10535082: /C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_HOST_BREAKPAD_H_

	6 #define REMOTING_HOST_BREAKPAD_H_
	Peter Kasting 2012/06/14 20:16:27 I'm not a big fan of having two headers named iden I'm not a big fan of having two headers named identically in parallel subdirectories. Not only is it confusing which one to use, but this makes it harder to e.g. "open breakpad.h" in the Visual Studio command prompt and get the right one. Can we combine these into one header, or rename them and make it clear why they should be separate? (The same goes for breakpad_win.cc.) alexeypa (please no reviews) 2012/06/15 18:45:49 Agree. It makes sense to rename host/breakpad. i Show quoted text On 2012/06/14 20:16:27, Peter Kasting wrote: > I'm not a big fan of having two headers named identically in parallel > subdirectories. Not only is it confusing which one to use, but this makes it > harder to e.g. "open breakpad.h" in the Visual Studio command prompt and get the > right one. > > Can we combine these into one header, or rename them and make it clear why they > should be separate? > > (The same goes for breakpad_win.cc.) Agree. It makes sense to rename host/breakpad. into host/usage_stats_consent.. Note that there is a later CL that renames CrashReporting into UsageStats for consistency reasons. There is also a similar issue with constants.* which is going to be consolidated by a separate CL.
	7

	8 namespace remoting {

	9

	10 // Returns true if the user has agreed to crash dump collection and uploading.

	11 bool IsCrashReportingEnabled();

	12

	13 } // remoting

	14

	15 #endif // REMOTING_HOST_BREAKPAD_H_

OLD	NEW

« remoting/base/breakpad_win_unittest.cc ('K') | « remoting/base/breakpad_win_unittest.cc ('k') | remoting/host/breakpad_win.cc » ('j') | remoting/host/breakpad_win.cc » ('J')