remoting/base/breakpad_mac.mm - Issue 10535082: /C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/base/breakpad_mac.mm

Issue 10535082: /C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "remoting/base/breakpad.h"

	6

	7 namespace remoting {

	8

	9 void InitializeCrashReporting() {

	10 // Do nothing because crash dump reporting on Mac is initialized from

	11 // awakeFromNib method.
	Peter Kasting 2012/06/14 20:16:27 Nit: Is it possible to point to where that method Nit: Is it possible to point to where that method is defined? ("...initialized in awakeFromNib(); see src/blah/foo/x.mm.") alexeypa (please no reviews) 2012/06/15 18:45:49 awakeFromNib() belongs to an object that controls Show quoted text On 2012/06/14 20:16:27, Peter Kasting wrote: > Nit: Is it possible to point to where that method is defined? ("...initialized > in awakeFromNib(); see src/blah/foo/x.mm.") awakeFromNib() belongs to an object that controls life time of the Breakpad object. I'd put this to the comment but it seems that awakeFromNib() is not the only way how it can be done. So I'll put a generic "Implement crash dump collection on Mac" instead.
	12 }

	13

	14 } // namespace remoting

OLD	NEW

« remoting/base/breakpad_linux.cc ('K') | « remoting/base/breakpad_linux.cc ('k') | remoting/base/breakpad_win.cc » ('j') | remoting/base/breakpad_win.cc » ('J')