Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/tcmalloc/chromium/src/base/abort.h

Issue 10535049: Try not to inline tcmalloc::Abort() so we can find it in stack trace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/allocator/allocator.gyp ('k') | third_party/tcmalloc/chromium/src/base/abort.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/tcmalloc/chromium/src/base/abort.h
===================================================================
--- third_party/tcmalloc/chromium/src/base/abort.h (revision 140872)
+++ third_party/tcmalloc/chromium/src/base/abort.h (working copy)
@@ -6,29 +6,14 @@
// On some platforms abort() is implemented in a way that Chrome's crash
// reporter treats it as a normal exit. See issue:
// http://code.google.com/p/chromium/issues/detail?id=118665
-// So we replace abort with a
-// segmentation fault, that crash reporter can always detect.
+// So we replace abort with a segmentation fault, then crash reporter can
+// always detect.
#ifndef BASE_ABORT_H_
#define BASE_ABORT_H_
-#if defined(TCMALLOC_USE_SYSTEM_ABORT)
-#include <stdlib.h>
-
namespace tcmalloc {
-inline void Abort() {
- abort();
-}
+void Abort();
} // namespace tcmalloc
-#else
-namespace tcmalloc {
-inline void Abort() {
- // Make a segmentation fault to force abort.
- *reinterpret_cast<volatile int*>(NULL) = 0x2001;
-}
-} // namespace tcmalloc
-
-#endif
-
#endif // BASE_ABORT_H_
« no previous file with comments | « base/allocator/allocator.gyp ('k') | third_party/tcmalloc/chromium/src/base/abort.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698