Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/tcmalloc/chromium/src/base/abort.h

Issue 10535049: Try not to inline tcmalloc::Abort() so we can find it in stack trace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // --- 5 // ---
6 // On some platforms abort() is implemented in a way that Chrome's crash 6 // On some platforms abort() is implemented in a way that Chrome's crash
7 // reporter treats it as a normal exit. See issue: 7 // reporter treats it as a normal exit. See issue:
8 // http://code.google.com/p/chromium/issues/detail?id=118665 8 // http://code.google.com/p/chromium/issues/detail?id=118665
9 // So we replace abort with a 9 // So we replace abort with a segmentation fault, then crash reporter can
10 // segmentation fault, that crash reporter can always detect. 10 // always detect.
11 11
12 #ifndef BASE_ABORT_H_ 12 #ifndef BASE_ABORT_H_
13 #define BASE_ABORT_H_ 13 #define BASE_ABORT_H_
14 14
15 #if defined(TCMALLOC_USE_SYSTEM_ABORT)
16 #include <stdlib.h>
17
18 namespace tcmalloc { 15 namespace tcmalloc {
19 inline void Abort() { 16 void Abort();
20 abort();
21 }
22 } // namespace tcmalloc 17 } // namespace tcmalloc
23 18
24 #else
25 namespace tcmalloc {
26 inline void Abort() {
27 // Make a segmentation fault to force abort.
28 *reinterpret_cast<volatile int*>(NULL) = 0x2001;
29 }
30 } // namespace tcmalloc
31
32 #endif
33
34 #endif // BASE_ABORT_H_ 19 #endif // BASE_ABORT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698