Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: third_party/tcmalloc/chromium/src/base/abort.cc

Issue 10535049: Try not to inline tcmalloc::Abort() so we can find it in stack trace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « third_party/tcmalloc/chromium/src/base/abort.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Property Changes:
Added: svn:executable
## -0,0 +1 ##
+*
\ No newline at end of property
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/abort.h"
6
7 #if defined(TCMALLOC_USE_SYSTEM_ABORT)
8 #include <stdlib.h>
9 #endif
10 #include "base/basictypes.h"
11
12 namespace tcmalloc {
13
14 // Don't inline so we can find Abort() call from stack trace.
15 ATTRIBUTE_NOINLINE void Abort() {
16 #if defined(TCMALLOC_USE_SYSTEM_ABORT)
17 abort();
18 #else
19 // Make a segmentation fault to force abort.
20 *reinterpret_cast<volatile int*>(NULL) = 0x2001;
jar (doing other things) 2012/06/08 21:02:31 Suggest simplifying to never call system abort. I
21 #endif
22 }
23
24 } // namespace tcmalloc
OLDNEW
« no previous file with comments | « third_party/tcmalloc/chromium/src/base/abort.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698