Add Windows commandline switch --enable-views-textfield.

ui/views/controls/textfield/textfield.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield.h"
 
 #include <string>
 
+#include "base/command_line.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "ui/base/accessibility/accessible_view_state.h"
 #include "ui/base/ime/text_input_type.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 #include "ui/base/range/range.h"
+#include "ui/base/ui_base_switches.h"
 #include "ui/gfx/insets.h"
 #include "ui/gfx/selection_model.h"
 #include "ui/views/controls/native/native_view_host.h"
+#include "ui/views/controls/textfield/native_textfield_views.h"
 #include "ui/views/controls/textfield/native_textfield_wrapper.h"
 #include "ui/views/controls/textfield/textfield_controller.h"
 #include "ui/views/widget/widget.h"
 
 #if defined(OS_WIN)
 #include "base/win/win_util.h"
 // TODO(beng): this should be removed when the OS_WIN hack from
 // ViewHierarchyChanged is removed.
-#include "ui/views/controls/textfield/native_textfield_views.h"
 #include "ui/views/controls/textfield/native_textfield_win.h"
 #endif
 
 namespace {
 
 // Default placeholder text color.
 const SkColor kDefaultPlaceholderTextColor = SK_ColorLTGRAY;
 
+#if defined(OS_WIN) && !defined(USE_AURA)
+bool UseNativeTextfieldViews() {
+  CommandLine* command_line = CommandLine::ForCurrentProcess();
+  return command_line->HasSwitch(switches::kEnableViewsTextfield);
+}
+#endif
+
 }  // namespace
 
 namespace views {
 
 // static
 const char Textfield::kViewClassName[] = "views/Textfield";
 
 /////////////////////////////////////////////////////////////////////////////
 // Textfield
 
@@ skipping 315 matching lines @@
                        insets.width(), font_height + insets.height());
 }
 
 void Textfield::AboutToRequestFocusFromTabTraversal(bool reverse) {
   SelectAll();
 }
 
 bool Textfield::SkipDefaultKeyEventProcessing(const KeyEvent& e) {
   // TODO(hamaji): Figure out which keyboard combinations we need to add here,
   //               similar to LocationBarView::SkipDefaultKeyEventProcessing.
-  ui::KeyboardCode key = e.key_code();
-  if (key == ui::VKEY_BACK)
+  if (e.key_code() == ui::VKEY_BACK)
     return true;  // We'll handle BackSpace ourselves.
 
 #if defined(USE_AURA)
   NOTIMPLEMENTED();
 #elif defined(OS_WIN)
   // We don't translate accelerators for ALT + NumPad digit on Windows, they are
   // used for entering special characters.  We do translate alt-home.
-  if (e.IsAltDown() && (key != ui::VKEY_HOME) &&
-      NativeTextfieldWin::IsNumPadDigit(key,
-                                        (e.flags() & ui::EF_EXTENDED) != 0))
+  if (e.IsAltDown() && (e.key_code() != ui::VKEY_HOME) && e.IsNumPadDigit())
     return true;
 #endif
   return false;
 }
 
 void Textfield::OnPaintFocusBorder(gfx::Canvas* canvas) {
   if (NativeViewHost::kRenderNativeControlFocus)
     View::OnPaintFocusBorder(canvas);
 }
 
@@ skipping 55 matching lines @@
 
     // The native wrapper's lifetime will be managed by the view hierarchy after
     // we call AddChildView.
     native_wrapper_ = NativeTextfieldWrapper::CreateWrapper(this);
     AddChildView(native_wrapper_->GetView());
     // TODO(beng): Move this initialization to NativeTextfieldWin once it
     //             subclasses NativeControlWin.
     UpdateAllProperties();
 
 #if defined(OS_WIN) && !defined(USE_AURA)
-    // TODO(beng): remove this once NativeTextfieldWin subclasses
+    // TODO(beng): Remove this once NativeTextfieldWin subclasses
     // NativeControlWin. This is currently called to perform post-AddChildView
     // initialization for the wrapper.
     //
     // Remove the include for native_textfield_win.h above when you fix this.
-    static_cast<NativeTextfieldWin*>(native_wrapper_)->AttachHack();
+    if (!UseNativeTextfieldViews())
+      static_cast<NativeTextfieldWin*>(native_wrapper_)->AttachHack();
 #endif
   }
 }
 
 std::string Textfield::GetClassName() const {
   return kViewClassName;
 }
 
+////////////////////////////////////////////////////////////////////////////////
+// NativeTextfieldWrapper, public:
+
+// static
+NativeTextfieldWrapper* NativeTextfieldWrapper::CreateWrapper(
+    Textfield* field) {
+#if defined(OS_WIN) && !defined(USE_AURA)
+  if (!UseNativeTextfieldViews())

[tfarina, 2012/06/08 00:15:00]

nit: what happens if this is true? Is that even possible?

[msw, 2012/06/08 00:23:49]

I'm not sure I understand what you're asking. Both cases are possible and work
as I expect. If the user doesn't explicitly supply --enable-views-textfield,
we'll use the classic, well-supported NativeTextfieldWin behavior already in
production. Otherwise, we'll use the more experimental NativeTextfieldViews.

+    return new NativeTextfieldWin(field);
+#endif
+  return new NativeTextfieldViews(field);
+}
+
 }  // namespace views