Move creation and ownership of DownloadManager from the embedder to content. This matches all the o…

content/public/browser/browser_context.h

Index: content/public/browser/browser_context.h
===================================================================
--- content/public/browser/browser_context.h	(revision 140592)
+++ content/public/browser/browser_context.h	(working copy)
@@ -37,6 +37,7 @@
 
 class DOMStorageContext;
 class DownloadManager;
+class DownloadManagerDelegate;
 class GeolocationPermissionContext;
 class IndexedDBContext;
 class ResourceContext;
@@ -46,6 +47,7 @@
 // It lives on the UI thread.
 class CONTENT_EXPORT BrowserContext : public base::SupportsUserData {
  public:
+  static DownloadManager* GetDownloadManager(BrowserContext* browser_context);

[Avi (use Gerrit), 2012/06/05 23:38:22]

My concern is that this is a call-once-only function among the others
immediately below which you can call all you want.

   static quota::QuotaManager* GetQuotaManager(BrowserContext* browser_context);
   static DOMStorageContext* GetDOMStorageContext(
       BrowserContext* browser_context);
@@ -80,9 +82,6 @@
   // This doesn't belong here; http://crbug.com/89628
   virtual bool IsOffTheRecord() const = 0;
 
-  // Returns the DownloadManager associated with this context.
-  virtual content::DownloadManager* GetDownloadManager() = 0;
-
   // Returns the request context information associated with this context.  Call
   // this only on the UI thread, since it can send notifications that should
   // happen on the UI thread.
@@ -104,6 +103,10 @@
   // Returns the resource context.
   virtual ResourceContext* GetResourceContext() = 0;
 
+  // Returns the DownloadManagerDelegate for this context. This will be called
+  // once per context. It's valid to return NULL.
+  virtual DownloadManagerDelegate* GetDownloadManagerDelegate() = 0;
+
   // Returns the geolocation permission context for this context.
   virtual GeolocationPermissionContext* GetGeolocationPermissionContext() = 0;