Issue 10534166: Fix to prevent traversal into '.' directories when collecting file search proposals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10534166: Fix to prevent traversal into '.' directories when collecting file search proposals. (Closed)

Created:
8 years, 6 months ago by pquitslund

Modified:
8 years, 6 months ago

Reviewers:
devoncarew

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix to prevent traversal into '.' directories when collecting file search proposals. dartbug.com/3648 Committed: https://code.google.com/p/dart/source/detail?r=8691

Patch Set 2 : #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/omni/elements/FileProvider.java	View	1	4 chunks	+11 lines, -5 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pquitslund

http://codereview.chromium.org/10534166/diff/2001/editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/omni/elements/FileProvider.java File editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/omni/elements/FileProvider.java (right): http://codereview.chromium.org/10534166/diff/2001/editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/omni/elements/FileProvider.java#newcode169 editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/omni/elements/FileProvider.java:169: return name != null && !name.startsWith("."); Since I'm in ...

8 years, 6 months ago (2012-06-14 21:02:20 UTC) #1

lgtm

Expand Messages | Collapse Messages

Issue 10534166: Fix to prevent traversal into '.' directories when collecting file search proposals. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages