chrome/test/automation/browser_proxy.cc - Issue 10534163: First pass at refactoring pyautolib in preparation for removing proxy dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/automation/browser_proxy.cc

Issue 10534163: First pass at refactoring pyautolib in preparation for removing proxy dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Switched AutomationMsg_SendJSONRequest to use a browser index, now only browser_proxy uses browser … Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/automation/browser_proxy.cc

diff --git a/chrome/test/automation/browser_proxy.cc b/chrome/test/automation/browser_proxy.cc

index a0e18bc816825db7a5842ac9885e07fd5078055f..867de74306a9893a52ead4f106b8e8e3a69c0c60 100644

--- a/chrome/test/automation/browser_proxy.cc

+++ b/chrome/test/automation/browser_proxy.cc

@@ -428,11 +428,12 @@ bool BrowserProxy::SendJSONRequest(const std::string& request,

return false;

bool result = false;

- if (!sender_->Send(new AutomationMsg_SendJSONRequest(handle_,

- request,

- response,

- &result),

- timeout_ms))

+ if (!sender_->Send(

+ new AutomationMsg_SendJSONRequestWithBrowserHandle(handle_,

+ request,

+ response,

+ &result),

+ timeout_ms))

return false;

return result;

}

« chrome/common/automation_messages_internal.h ('K') | « chrome/common/automation_messages_internal.h ('k') | chrome/test/functional/test_pyauto.py » ('j') | no next file with comments »