Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: ui/base/ime/input_method_ibus.cc

Issue 10534134: Fix candidate window position issue. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: address comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/ibus_client_impl.cc ('k') | ui/base/ime/mock_ibus_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_ibus.cc
diff --git a/ui/base/ime/input_method_ibus.cc b/ui/base/ime/input_method_ibus.cc
index d9a35cbb629c76f7ab88d1edd5df083f75f54943..d7a3e3a45bae1351cabd8331a049b9149b7ca441 100644
--- a/ui/base/ime/input_method_ibus.cc
+++ b/ui/base/ime/input_method_ibus.cc
@@ -334,9 +334,13 @@ void InputMethodIBus::OnCaretBoundsChanged(const TextInputClient* client) {
DCHECK(!IsTextInputTypeNone());
const gfx::Rect rect = GetTextInputClient()->GetCaretBounds();
+ gfx::Rect composition_head;
+ if (!GetTextInputClient()->GetCompositionCharacterBounds(0,
+ &composition_head))
Yusuke Sato 2012/06/13 15:17:38 {} is needed for a multi-line if.
Seigo Nonaka 2012/06/14 01:04:57 Done.
+ composition_head = gfx::Rect();
+
// This function runs asynchronously.
- ibus_client_->SetCursorLocation(
- context_, rect.x(), rect.y(), rect.width(), rect.height());
+ ibus_client_->SetCursorLocation(context_, rect, composition_head);
}
void InputMethodIBus::CancelComposition(const TextInputClient* client) {
« no previous file with comments | « ui/base/ime/ibus_client_impl.cc ('k') | ui/base/ime/mock_ibus_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698