Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10534129: NetLogEventParameter to Callback refactoring 5. (Closed)

Created:
8 years, 6 months ago by mmenke
Modified:
8 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

NetLogEventParameter to Callback refactoring 5. Get rid of all uses of NetLogEventParameters in net/http. R=eroman@chromium.org BUG=126243 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142009

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add back original URLs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -186 lines) Patch
M net/http/http_auth_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_cache_transaction.cc View 12 chunks +13 lines, -13 lines 0 comments Download
M net/http/http_network_transaction.cc View 8 chunks +28 lines, -49 lines 0 comments Download
M net/http/http_pipelined_connection_impl.cc View 6 chunks +30 lines, -48 lines 0 comments Download
M net/http/http_proxy_client_socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 4 chunks +21 lines, -65 lines 0 comments Download
M net/http/http_stream_factory_impl_request.cc View 1 4 chunks +5 lines, -6 lines 0 comments Download
M net/http/http_stream_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mmenke
8 years, 6 months ago (2012-06-13 14:58:12 UTC) #1
eroman
lgtm http://codereview.chromium.org/10534129/diff/1/net/http/http_stream_factory_impl_job.cc File net/http/http_stream_factory_impl_job.cc (right): http://codereview.chromium.org/10534129/diff/1/net/http/http_stream_factory_impl_job.cc#newcode48 net/http/http_stream_factory_impl_job.cc:48: dict->SetString("original_url", original_url->spec()); This is different, is that intentional? ...
8 years, 6 months ago (2012-06-13 18:44:06 UTC) #2
mmenke
*sigh*. My week of stupid mistakes. http://codereview.chromium.org/10534129/diff/1/net/http/http_stream_factory_impl_job.cc File net/http/http_stream_factory_impl_job.cc (right): http://codereview.chromium.org/10534129/diff/1/net/http/http_stream_factory_impl_job.cc#newcode48 net/http/http_stream_factory_impl_job.cc:48: dict->SetString("original_url", original_url->spec()); On ...
8 years, 6 months ago (2012-06-13 19:06:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10534129/1011
8 years, 6 months ago (2012-06-13 19:07:14 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-13 23:14:43 UTC) #5
Change committed as 142009

Powered by Google App Engine
This is Rietveld 408576698