Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1703)

Unified Diff: net/base/x509_certificate_net_log_param.h

Issue 10534117: Fix NetLog thread safety issue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Update text Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/x509_certificate_net_log_param.h
===================================================================
--- net/base/x509_certificate_net_log_param.h (revision 141669)
+++ net/base/x509_certificate_net_log_param.h (working copy)
@@ -12,10 +12,11 @@
class X509Certificate;
-// Creates NetLog parameter to describe an X509Certificate.
-base::Value* NetLogX509CertificateCallback(
- const X509Certificate* certificate,
- NetLog::LogLevel log_level);
+// Creates a NetLog callback that returns a Value describing an X509Certificate.
+// The callback holds on to a reference to the certificate, which must not be
+// modified until the callback is destroyed.
+NetLog::ParametersCallback CreateNetLogX509CertificateCallback(
+ scoped_refptr<const X509Certificate> certificate);
Ryan Sleevi 2012/06/12 20:22:09 const scoped_refptr<>& Only scoped_ptr<>'s should
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698