Fix NetLog thread safety issue

net/socket/ssl_client_socket_nss.cc

Index: net/socket/ssl_client_socket_nss.cc
===================================================================
--- net/socket/ssl_client_socket_nss.cc	(revision 141669)
+++ net/socket/ssl_client_socket_nss.cc	(working copy)
@@ -2529,9 +2529,11 @@
   nss_handshake_state_.server_cert = X509Certificate::CreateFromDERCertChain(
       nss_handshake_state_.server_cert_chain.AsStringPieceVector());
   if (nss_handshake_state_.server_cert) {
+    // Since this will be called asynchronously on another thread, it needs to
+    // own a reference to the certificate.
     NetLog::ParametersCallback net_log_callback =
         base::Bind(&NetLogX509CertificateCallback,
-                   base::Unretained(nss_handshake_state_.server_cert.get()));
+                   base::ConstRef(nss_handshake_state_.server_cert));

[Ryan Sleevi, 2012/06/12 21:33:26]

This is still wrong.

ConstRefWrapper stores a ConstRef, rather than taking a copy/ownership.

If you were to use base::ConstRef, then you would have kept the change as you
originally had it, added base::ConstRef to every other call, and kept this one
as a non-const-ref.

base::ConstRef is more or less base::Unretained(), but for ref-args rather than
pointer args.

     PostOrRunCallback(
         FROM_HERE,
         base::Bind(&AddLogEventWithCallback, weak_net_log_,