Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: media/filters/chunk_demuxer_unittest.cc

Issue 10534096: Generalize AesDecryptor to make it more spec compliant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revise on comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/chunk_demuxer_unittest.cc
diff --git a/media/filters/chunk_demuxer_unittest.cc b/media/filters/chunk_demuxer_unittest.cc
index 0b518cd8bd688b74fa2574fa93f028f50d1ba3a8..6a6407954769d97a139c33a3bcb521d621011786 100644
--- a/media/filters/chunk_demuxer_unittest.cc
+++ b/media/filters/chunk_demuxer_unittest.cc
@@ -90,11 +90,12 @@ class MockChunkDemuxerClient : public ChunkDemuxerClient {
MOCK_METHOD1(DemuxerOpened, void(ChunkDemuxer* demuxer));
MOCK_METHOD0(DemuxerClosed, void());
// TODO(xhwang): This is a workaround of the issue that move-only parameters
- // are not supported in mocked methods. Remove this when the issue is fixed.
- // See http://code.google.com/p/googletest/issues/detail?id=395
- MOCK_METHOD2(KeyNeededMock, void(const uint8* init_data, int init_data_size));
- void KeyNeeded(scoped_array<uint8> init_data, int init_data_size) {
- KeyNeededMock(init_data.get(), init_data_size);
+ // are not supported in mocked methods. Remove this when the issue is fixed
+ // (http://code.google.com/p/googletest/issues/detail?id=395) or when we use
+ // std::string instead of scoped_array<uint8> (http://crbug.com/130689).
+ MOCK_METHOD2(NeedKeyMock, void(const uint8* init_data, int init_data_size));
+ void DemuxerNeedKey(scoped_array<uint8> init_data, int init_data_size) {
+ NeedKeyMock(init_data.get(), init_data_size);
}
private:
@@ -577,7 +578,7 @@ TEST_F(ChunkDemuxerTest, TestInit) {
client_.reset(new MockChunkDemuxerClient());
demuxer_ = new ChunkDemuxer(client_.get());
if (has_video && video_content_encoded)
- EXPECT_CALL(*client_, KeyNeededMock(NotNull(), 16));
+ EXPECT_CALL(*client_, NeedKeyMock(NotNull(), 16));
ASSERT_TRUE(InitDemuxer(has_audio, has_video, video_content_encoded));
@@ -883,7 +884,7 @@ TEST_F(ChunkDemuxerTest, TestNetworkErrorEndOfStream) {
// Read() behavior.
class EndOfStreamHelper {
public:
- EndOfStreamHelper(const scoped_refptr<Demuxer> demuxer)
+ explicit EndOfStreamHelper(const scoped_refptr<Demuxer> demuxer)
: demuxer_(demuxer),
audio_read_done_(false),
video_read_done_(false) {

Powered by Google App Engine
This is Rietveld 408576698