Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1561)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10534080: sync: move internal_api components used by chrome/browser into internal_api/public (Closed)

Created:
8 years, 6 months ago by tim (not reviewing)
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

sync: move internal_api components used by chrome/browser into internal_api/public TBR=jhawkins@chromium.org BUG=131130 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142626

Patch Set 1 #

Patch Set 2 : fix guard #

Patch Set 3 : init #

Total comments: 3

Patch Set 4 : temp deps #

Patch Set 5 : test_id_factory #

Patch Set 6 : fix #

Patch Set 7 : rebase #

Patch Set 8 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -3434 lines) Patch
M chrome/browser/sync/DEPS View 1 2 3 4 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/sync/abstract_profile_sync_service_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/abstract_profile_sync_service_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/backend_migrator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/backend_migrator_unittest.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/backend_unrecoverable_error_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/backend_data_type_configurer.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/change_processor_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_error_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/shared_change_processor_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 1 2 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_change_processor.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/theme_model_associator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 2 3 4 5 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 1 2 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 2 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/enable_disable_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/test_http_bridge_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M sync/api/sync_data.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sync/api/sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/sync_scheduler.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
D sync/internal_api/base_node.h View 1 chunk +0 lines, -255 lines 0 comments Download
M sync/internal_api/base_node.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D sync/internal_api/base_transaction.h View 1 chunk +0 lines, -54 lines 0 comments Download
M sync/internal_api/base_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
D sync/internal_api/change_record.h View 1 chunk +0 lines, -67 lines 0 comments Download
M sync/internal_api/change_record.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D sync/internal_api/change_record_unittest.cc View 1 2 1 chunk +0 lines, -137 lines 0 comments Download
M sync/internal_api/change_reorder_buffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/change_reorder_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
D sync/internal_api/configure_reason.h View 1 chunk +0 lines, -36 lines 0 comments Download
M sync/internal_api/debug_info_event_listener.h View 1 chunk +2 lines, -2 lines 0 comments Download
D sync/internal_api/http_post_provider_factory.h View 1 chunk +0 lines, -34 lines 0 comments Download
D sync/internal_api/http_post_provider_interface.h View 1 2 3 4 1 chunk +0 lines, -67 lines 0 comments Download
M sync/internal_api/js_mutation_event_observer.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/js_mutation_event_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/js_sync_manager_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/js_sync_manager_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/DEPS View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A + sync/internal_api/public/base_node.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + sync/internal_api/public/base_transaction.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/public/change_record.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/public/change_record_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/public/configure_reason.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sync/internal_api/public/http_post_provider_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sync/internal_api/public/http_post_provider_interface.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + sync/internal_api/public/read_node.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/public/read_transaction.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/public/sync_manager.h View 1 2 3 4 5 6 3 chunks +8 lines, -8 lines 0 comments Download
A + sync/internal_api/public/test/test_user_share.h View 1 2 3 4 3 chunks +7 lines, -6 lines 0 comments Download
A + sync/internal_api/public/user_share.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sync/internal_api/public/util/experiments.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/internal_api/public/util/immutable.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/internal_api/public/util/immutable_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/public/util/report_unrecoverable_error_function.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/internal_api/public/util/unrecoverable_error_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/internal_api/public/util/unrecoverable_error_info.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/internal_api/public/util/unrecoverable_error_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/public/util/weak_handle.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/internal_api/public/util/weak_handle.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/public/util/weak_handle_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/public/write_node.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + sync/internal_api/public/write_transaction.h View 2 chunks +4 lines, -4 lines 0 comments Download
D sync/internal_api/read_node.h View 1 chunk +0 lines, -66 lines 0 comments Download
M sync/internal_api/read_node.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D sync/internal_api/read_transaction.h View 1 chunk +0 lines, -46 lines 0 comments Download
M sync/internal_api/read_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
D sync/internal_api/sync_manager.h View 1 2 3 4 5 6 1 chunk +0 lines, -580 lines 0 comments Download
M sync/internal_api/sync_manager.cc View 1 2 3 4 5 6 3 chunks +9 lines, -9 lines 0 comments Download
M sync/internal_api/syncapi_server_connection_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/syncapi_server_connection_manager_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/syncapi_unittest.cc View 1 2 3 4 5 6 1 chunk +9 lines, -9 lines 0 comments Download
A + sync/internal_api/test/test_user_share.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -5 lines 0 comments Download
D sync/internal_api/test_user_share.h View 1 chunk +0 lines, -67 lines 0 comments Download
D sync/internal_api/test_user_share.cc View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
D sync/internal_api/user_share.h View 1 chunk +0 lines, -36 lines 0 comments Download
M sync/internal_api/user_share.cc View 1 chunk +1 line, -1 line 0 comments Download
D sync/internal_api/write_node.h View 1 chunk +0 lines, -203 lines 0 comments Download
M sync/internal_api/write_node.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D sync/internal_api/write_transaction.h View 1 chunk +0 lines, -57 lines 0 comments Download
M sync/internal_api/write_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/js/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M sync/js/js_arg_list.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sync/js/js_event_details.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sync/js/js_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/js/sync_js_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M sync/notifier/chrome_invalidation_client.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/chrome_invalidation_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/invalidation_notifier.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/invalidation_notifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/non_blocking_invalidation_notifier.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/non_blocking_invalidation_notifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/sync_notifier_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/sync.gyp View 1 2 3 4 5 6 8 chunks +25 lines, -25 lines 0 comments Download
M sync/syncable/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M sync/syncable/syncable.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M sync/test/engine/test_directory_setter_upper.h View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M sync/test/null_transaction_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
D sync/util/experiments.h View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
D sync/util/immutable.h View 1 2 3 1 chunk +0 lines, -262 lines 0 comments Download
D sync/util/immutable_unittest.cc View 1 2 3 1 chunk +0 lines, -250 lines 0 comments Download
D sync/util/report_unrecoverable_error_function.h View 1 chunk +0 lines, -19 lines 0 comments Download
M sync/util/test_unrecoverable_error_handler.h View 1 chunk +1 line, -1 line 0 comments Download
D sync/util/unrecoverable_error_handler.h View 1 chunk +0 lines, -30 lines 0 comments Download
D sync/util/unrecoverable_error_info.h View 1 chunk +0 lines, -41 lines 0 comments Download
D sync/util/unrecoverable_error_info.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D sync/util/weak_handle.h View 1 chunk +0 lines, -379 lines 0 comments Download
D sync/util/weak_handle.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D sync/util/weak_handle_unittest.cc View 1 chunk +0 lines, -326 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tim (not reviewing)
Ready for review. Nicolas, the important parts are the DEPS files, the gyp changes, and ...
8 years, 6 months ago (2012-06-11 16:57:26 UTC) #1
Nicolas Zea
LGTM with nits http://codereview.chromium.org/10534080/diff/7002/sync/internal_api/public/DEPS File sync/internal_api/public/DEPS (right): http://codereview.chromium.org/10534080/diff/7002/sync/internal_api/public/DEPS#newcode6 sync/internal_api/public/DEPS:6: #FIXME BEFORE CHECKIN ! http://codereview.chromium.org/10534080/diff/7002/sync/sync.gyp File ...
8 years, 6 months ago (2012-06-11 18:13:59 UTC) #2
tim (not reviewing)
+jhawkins for ui//webui stamp
8 years, 6 months ago (2012-06-16 18:47:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/10534080/13162
8 years, 6 months ago (2012-06-16 20:08:33 UTC) #4
commit-bot: I haz the power
Try job failure for 10534080-13162 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 6 months ago (2012-06-16 21:25:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/10534080/13162
8 years, 6 months ago (2012-06-16 23:08:43 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-17 01:07:36 UTC) #7 
Change committed as 142626

Powered by Google App Engine
This is Rietveld 408576698