Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: ash/shell.cc

Issue 10534079: Add support for managing active state of platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use new launch_2 test platform app Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/base_window.h » ('j') | chrome/browser/ui/browser_window.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index b7f7443b5376b7398d8961bcfda81d346fea3325..37170b3c6e549ce01c270b2dd2e68f83b41de2dc 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -649,11 +649,6 @@ Shell::~Shell() {
aura::client::SetVisibilityClient(root_window, NULL);
visibility_controller_.reset();
- // Delete the activation controller after other controllers
- // because they might have registered ActivationChangeObserver.
- aura::client::SetActivationClient(root_window, NULL);
- activation_controller_.reset();
-
// Launcher widget has a InputMethodBridge that references to
// input_method_filter_'s input_method_. So explicitly release launcher_
// before input_method_filter_. And this needs to be after we delete all
@@ -661,6 +656,11 @@ Shell::~Shell() {
// LauncherModel during close.
launcher_.reset();
+ // Delete the activation controller after other controllers
+ // because they might have registered ActivationChangeObserver.
+ aura::client::SetActivationClient(root_window, NULL);
sky 2012/06/11 17:47:39 You're moving this because you want the launcher d
DaveMoore 2012/06/11 18:13:40 Done.
+ activation_controller_.reset();
+
DCHECK(instance_ == this);
instance_ = NULL;
« no previous file with comments | « no previous file | chrome/browser/ui/base_window.h » ('j') | chrome/browser/ui/browser_window.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698