[sync] Make SetSetupInProgress kick sync engine when needed

chrome/browser/sync/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service.h"
 
 #include <cstddef>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 983 matching lines @@
 }
 
 const GoogleServiceAuthError& ProfileSyncService::GetAuthError() const {
   return last_auth_error_;
 }
 
 bool ProfileSyncService::FirstSetupInProgress() const {
   return !HasSyncSetupCompleted() && setup_in_progress_;
 }
 
+void ProfileSyncService::SetSetupInProgress(bool setup_in_progress) {
+  setup_in_progress_ = setup_in_progress;
+  if (!setup_in_progress) {
+    if (sync_initialized()) {
+      SetSyncSetupCompleted();

[Andrew T Wilson (Slow), 2012/06/11 18:17:59]

I'm somewhat leery about calling SetSyncSetupCompleted() here - I wonder if
instead we should require the caller to call it, *before* calling
SetSetupInProgress(false).

Also, I think we should probably just call ReconfigureDatatypeManager() instead
of OnUserChoseDatatypes().

+      OnUserChoseDatatypes(sync_prefs_.HasKeepEverythingSynced(),
+                           GetPreferredDataTypes());
+    }
+  }
+}
+
 bool ProfileSyncService::sync_initialized() const {
   return backend_initialized_;
 }
 
 bool ProfileSyncService::waiting_for_auth() const {
   return is_auth_in_progress_;
 }
 
 bool ProfileSyncService::unrecoverable_error_detected() const {
   return unrecoverable_error_detected_;
@@ skipping 650 matching lines @@
   // See http://stackoverflow.com/questions/6224121/is-new-this-myclass-undefined-behaviour-after-directly-calling-the-destru.
   ProfileSyncService* old_this = this;
   this->~ProfileSyncService();
   new(old_this) ProfileSyncService(
       new ProfileSyncComponentsFactoryImpl(profile,
                                            CommandLine::ForCurrentProcess()),
       profile,
       signin,
       behavior);
 }