Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4366)

Unified Diff: chrome/browser/ui/views/location_bar/action_box_button_view.h

Issue 10533086: Action box menu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Action box menu Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/action_box_button_view.h
diff --git a/chrome/browser/ui/views/location_bar/action_box_button_view.h b/chrome/browser/ui/views/location_bar/action_box_button_view.h
index 522eb4e03120114a357c1a75a1ab0c6baeea9b90..7b59339c1ba20be2be78db4fefa0af43e0433f75 100644
--- a/chrome/browser/ui/views/location_bar/action_box_button_view.h
+++ b/chrome/browser/ui/views/location_bar/action_box_button_view.h
@@ -8,18 +8,32 @@
#include "ui/views/controls/button/menu_button.h"
#include "ui/views/controls/button/menu_button_listener.h"
-class ExtensionService;
+class ActionBoxMenu;
+class Browser;
+class Profile;
// ActionBoxButtonView displays a plus button with associated menu.
class ActionBoxButtonView : public views::MenuButton,
public views::MenuButtonListener {
public:
- explicit ActionBoxButtonView(ExtensionService* extension_service);
+ class Delegate {
+ public:
+ virtual Browser* GetBrowser() const = 0;
+
+ protected:
+ Delegate() {}
Peter Kasting 2012/07/14 02:08:01 Nit: No need to supply the constructor.
yefimt 2012/07/17 18:20:37 Done.
+ ~Delegate() {}
+ };
+
+ explicit ActionBoxButtonView(Profile* profile,
+ Delegate* delegate);
virtual ~ActionBoxButtonView();
SkColor GetBackgroundColor();
SkColor GetBorderColor();
+ void SetBookmarkState(bool on);
Peter Kasting 2012/07/14 02:08:01 Nit: Should be inlined and named set_bookmark_stat
yefimt 2012/07/17 18:20:37 Done.
+
private:
// CustomButton
virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
@@ -28,7 +42,13 @@ class ActionBoxButtonView : public views::MenuButton,
virtual void OnMenuButtonClicked(View* source,
const gfx::Point& point) OVERRIDE;
- ExtensionService* extension_service_;
+ Profile* profile_;
+
Peter Kasting 2012/07/14 02:08:01 Nit: Remove blank lines
yefimt 2012/07/17 18:20:37 Done.
+ Delegate* delegate_;
+
+ scoped_ptr<ActionBoxMenu> action_box_menu_;
+
+ bool bookmark_state_;
DISALLOW_COPY_AND_ASSIGN(ActionBoxButtonView);
};

Powered by Google App Engine
This is Rietveld 408576698