Action box menu

ui/views/controls/menu/menu_item_view.h

Index: ui/views/controls/menu/menu_item_view.h
diff --git a/ui/views/controls/menu/menu_item_view.h b/ui/views/controls/menu/menu_item_view.h
index 6f4b89ad6f60bfacfb1bd74faf8b2c899aa769f0..006f56e19bd1d887cd10a43a4b47f4076eec18a9 100644
--- a/ui/views/controls/menu/menu_item_view.h
+++ b/ui/views/controls/menu/menu_item_view.h
@@ -321,6 +321,13 @@ class VIEWS_EXPORT MenuItemView : public View {
 
   virtual std::string GetClassName() const OVERRIDE;
 
+  virtual MenuItemView* AllocateMenuItemView(MenuItemView* parent, int item_id,

[Aaron Boodman, 2012/06/12 05:53:44]

You're right, this looks like a funny change.

Instead, can we add MenuItemView::AppendItem(MenuItemView*), and then call that
instead of AppendItemFromModel()?

[yefimt, 2012/06/13 01:24:21]

Done.

+                                             Type type);
+
+  // Returns the various margins.
+  int GetTopMargin();

[Aaron Boodman, 2012/06/12 05:53:44]

This isn't called anywhere. Does it need to be public?

[yefimt, 2012/06/13 01:24:21]

Done.

+  int GetBottomMargin();
+
  private:
   friend class internal::MenuRunnerImpl;  // For access to ~MenuItemView.
 
@@ -382,10 +389,6 @@ class VIEWS_EXPORT MenuItemView : public View {
   // Returns the accelerator text.
   string16 GetAcceleratorText();
 
-  // Returns the various margins.
-  int GetTopMargin();
-  int GetBottomMargin();
-
   // Returns the preferred size (and padding) of any children.
   gfx::Size GetChildPreferredSize();