Action box menu

chrome/browser/extensions/extension_prefs.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 41 matching lines @@
   // is a dictionary object read from the Preferences file, keyed off of
   // extension ids.
   static const char kExtensionsPref[];
 
   typedef std::vector<linked_ptr<ExtensionInfo> > ExtensionsInfo;
 
   // Vector containing identifiers for preferences.
   typedef std::set<std::string> PrefKeySet;
 
   // Vector containing identifiers for extensions.
   typedef std::vector<std::string> ExtensionIdSet;

[Peter Kasting, 2012/07/26 20:37:17]

Nit: Not necessary in this change, but could you file a bug or something to
change this typedef name to ExtensionIds (preferred) or ExtensionIdList?  I ask
because ExtensionIdSet sounds like a set, not a vector, and
chrome/common/extensions/extension.h also defines an ExtensionIdSet type, which
actually is a set, so this could lead to bugs.

(If you want to change this in this CL since you're touching so many usages
that's fine too.)

[yefimt, 2012/07/31 00:10:11]

Ok, I wrote it down to my task list and added TODO comment

 
   // This enum is used for the launch type the user wants to use for an
   // application.
   // Do not remove items or re-order this enum as it is used in preferences
   // and histograms.
   enum LaunchType {
     LAUNCH_PINNED,
     LAUNCH_REGULAR,
     LAUNCH_FULLSCREEN,
     LAUNCH_WINDOW,
@@ skipping 22 matching lines @@
 
   // Returns true if the specified external extension was uninstalled by the
   // user.
   bool IsExternalExtensionUninstalled(const std::string& id) const;
 
   // Checks whether |extension_id| is disabled. If there's no state pref for
   // the extension, this will return false. Generally you should use
   // ExtensionService::IsExtensionEnabled instead.
   bool IsExtensionDisabled(const std::string& id) const;
 
-  // Get the order that the browser actions appear in the toolbar.
-  std::vector<std::string> GetToolbarOrder();
+  // Get/Set the order that the browser actions appear in the toolbar.
+  ExtensionIdSet GetToolbarOrder();
+  void SetToolbarOrder(const ExtensionIdSet& extension_ids);
 
-  // Set the order that the browser actions appear in the toolbar.
-  void SetToolbarOrder(const std::vector<std::string>& extension_ids);
+  // Get/Set the order that the browser actions appear in the action box.
+  ExtensionIdSet GetActionBoxOrder();
+  void SetActionBoxOrder(const ExtensionIdSet& extension_ids);
 
   // Called when an extension is installed, so that prefs get created.
   // If |page_ordinal| is an invalid ordinal, then a page will be found
   // for the App.
   void OnExtensionInstalled(const Extension* extension,
                             Extension::State initial_state,
                             bool from_webstore,
                             const StringOrdinal& page_ordinal);
 
   // Called when an extension is uninstalled, so that prefs get cleaned up.
@@ skipping 417 matching lines @@
   void InitPrefStore(bool extensions_disabled);
 
   // Migrates the permissions data in the pref store.
   void MigratePermissions(const ExtensionIdSet& extension_ids);
 
   // Checks whether there is a state pref for the extension and if so, whether
   // it matches |check_state|.
   bool DoesExtensionHaveState(const std::string& id,
                               Extension::State check_state) const;
 
+  // Helper function to Get/Set array of strings from/to prefs.
+  ExtensionIdSet GetExtensionPrefAsVector(const char* pref);
+  void SetExtensionPrefFromVector(const char* pref,
+                                  const ExtensionIdSet& extension_ids);
+
   // The pref service specific to this set of extension prefs. Owned by profile.
   PrefService* prefs_;
 
   // Base extensions install directory.
   FilePath install_directory_;
 
   // Weak pointer, owned by Profile.
   ExtensionPrefValueMap* extension_pref_value_map_;
 
   // Contains all the logic for handling the order for various extension
   // properties.
   scoped_ptr<ExtensionSorting> extension_sorting_;
 
   scoped_refptr<ContentSettingsStore> content_settings_store_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_