Action box menu

chrome/browser/ui/toolbar/action_box_menu_model.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/toolbar/action_box_menu_model.h"
+
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/extensions/extension_toolbar_model.h"
+#include "chrome/browser/extensions/extension_service.h"
+
+// Arbitrary number just to leave enough space for menu ids
+// that shown before extensions.

[msw, 2012/07/24 23:41:55]

grammar nit: "that show"

[yefimt, 2012/07/25 21:09:21]

Done.

+static const int kFirstExtensionCommandId = 1000;
+
+////////////////////////////////////////////////////////////////////////////////
+// ActionBoxMenuModel
+
+ActionBoxMenuModel::ActionBoxMenuModel(ExtensionService* extension_service)
+    : ALLOW_THIS_IN_INITIALIZER_LIST(ui::SimpleMenuModel(this)),
+      extension_service_(extension_service) {
+  Build();
+}
+
+ActionBoxMenuModel::~ActionBoxMenuModel() {
+}
+
+void ActionBoxMenuModel::ExecuteCommand(int command_id) {
+}
+
+bool ActionBoxMenuModel::IsCommandIdChecked(int command_id) const {
+  return false;
+}
+
+bool ActionBoxMenuModel::IsCommandIdEnabled(int command_id) const {
+  return true;
+}
+
+bool ActionBoxMenuModel::GetAcceleratorForCommandId(
+    int command_id,
+    ui::Accelerator* accelerator) {
+  return false;
+}
+
+void ActionBoxMenuModel::Observe(int type,
+                                 const content::NotificationSource& source,
+                                 const content::NotificationDetails& details) {
+}
+
+size_t ActionBoxMenuModel::action_box_extensions_size() {

[msw, 2012/07/24 23:41:55]

nit: definition order should match declaration order in the header.

[yefimt, 2012/07/25 21:09:21]

Done.

+  return extension_service_->toolbar_model()->action_box_extensions_size();
+}
+
+const extensions::Extension*
+    ActionBoxMenuModel::GetActionBoxExtensionByIndex(int index) {

[msw, 2012/07/24 23:41:55]

nit: definition order should match declaration order in the header.

[yefimt, 2012/07/25 21:09:21]

Done.

+  return extension_service_->toolbar_model()->
+      GetActionBoxExtensionByIndex(index);
+}
+
+void ActionBoxMenuModel::Build() {
+  int command_id = kFirstExtensionCommandId;
+  for (size_t i = 0; i < action_box_extensions_size(); ++i) {
+    const extensions::Extension* extension = GetActionBoxExtensionByIndex(i);
+    AddItem(command_id, UTF8ToUTF16(extension->name()));
+    id_to_extension_id_[command_id++] = extension->id();
+  }
+}