Action box menu

chrome/browser/extensions/extension_prefs.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 85 matching lines @@
   // Returns true if the specified external extension was uninstalled by the
   // user.
   bool IsExternalExtensionUninstalled(const std::string& id) const;
 
   // Checks whether |extension_id| is disabled. If there's no state pref for
   // the extension, this will return false. Generally you should use
   // ExtensionService::IsExtensionEnabled instead.
   bool IsExtensionDisabled(const std::string& id) const;
 
   // Get the order that the browser actions appear in the toolbar.
   std::vector<std::string> GetToolbarOrder();

[Peter Kasting, 2012/07/21 01:55:13]

Nit: The actual implementation of this uses ExtensionIdSet, which is already a
public typedef to vector<string>.  Can you make
[Get,Set][Toolbar,ActionBox]Order() (and the new helpers they use) consistently
use ExtensionIdSet everywhere they currently use vector<string> (in both the
header and .cc file)?  This will allow you to use this same typedef in
extension_toolbar_model.* instead of defining a new one that has to match the
type used here.

[yefimt, 2012/07/23 23:47:52]

Done.

 
   // Set the order that the browser actions appear in the toolbar.

[Peter Kasting, 2012/07/21 01:55:13]

Nit: Eliminate this comment and the blank line above in favor of using "Get/Set"
like you have in the comment for [Get,Set]ActionBoxOrder().

[yefimt, 2012/07/23 23:47:52]

Done.

   void SetToolbarOrder(const std::vector<std::string>& extension_ids);
 
+  // Get/Set the order that the browser actions appear in the action box.
+  std::vector<std::string> GetActionBoxOrder();
+  void SetActionBoxOrder(const std::vector<std::string>& extension_ids);
+
   // Called when an extension is installed, so that prefs get created.
   // If |page_ordinal| is an invalid ordinal, then a page will be found
   // for the App.
   void OnExtensionInstalled(const Extension* extension,
                             Extension::State initial_state,
                             bool from_webstore,
                             const StringOrdinal& page_ordinal);
 
   // Called when an extension is uninstalled, so that prefs get cleaned up.
   void OnExtensionUninstalled(const std::string& extension_id,
@@ skipping 416 matching lines @@
   void InitPrefStore(bool extensions_disabled);
 
   // Migrates the permissions data in the pref store.
   void MigratePermissions(const ExtensionIdSet& extension_ids);
 
   // Checks whether there is a state pref for the extension and if so, whether
   // it matches |check_state|.
   bool DoesExtensionHaveState(const std::string& id,
                               Extension::State check_state) const;
 
+  // Helper function to Get/Set array of strings from/to prefs.
+  std::vector<std::string> GetExtensionPrefAsVector(const char* pref);
+  void SetExtensionPrefFromVector(
+      const char* pref,
+      const std::vector<std::string>& extension_ids);
+
   // The pref service specific to this set of extension prefs. Owned by profile.
   PrefService* prefs_;
 
   // Base extensions install directory.
   FilePath install_directory_;
 
   // Weak pointer, owned by Profile.
   ExtensionPrefValueMap* extension_pref_value_map_;
 
   // Contains all the logic for handling the order for various extension
   // properties.
   scoped_ptr<ExtensionSorting> extension_sorting_;
 
   scoped_refptr<ContentSettingsStore> content_settings_store_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_