Action box menu

chrome/browser/ui/views/action_box_menu.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/action_box_menu.h"
+
+#include "chrome/browser/ui/toolbar/action_box_menu_model.h"
+#include "chrome/browser/ui/views/browser_action_view.h"
+#include "grit/generated_resources.h"
+#include "grit/theme_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/views/bubble/bubble_border.h"
+#include "ui/views/controls/button/menu_button.h"
+#include "ui/views/controls/menu/menu_runner.h"
+#include "ui/views/view.h"
+
+////////////////////////////////////////////////////////////////////////////////
+// ActionBoxMenu
+
+ActionBoxMenu::ActionBoxMenu(Browser* browser,
+                             ActionBoxMenuModel* model,
+                             bool bookmark_item_state)
+    : browser_(browser),
+      root_(NULL),
+      model_(model),
+      bookmark_item_state_(bookmark_item_state) {
+}
+
+ActionBoxMenu::~ActionBoxMenu() {
+}
+
+void ActionBoxMenu::Init() {
+  CHECK(!root_);

[Peter Kasting, 2012/07/18 01:37:25]

Nit: Why does this need to be a CHECK() rather than a DCHECK()?

[yefimt, 2012/07/18 23:18:13]

I guess because another reviewer asked me to change it to CHECK()

[Peter Kasting, 2012/07/19 04:27:31]

CHECKs are unusual -- normally they're used in situations where:
(a) We're trying to track down a crash by converting DCHECKs to CHECKs to see
which of our assertions fail, or
(b) If a particular condition doesn't hold, we must crash the browser
immediately rather than proceed, because we will otherwise have a critical
security hole, or whatever.

In this case it doesn't seem like either of these apply, so I would probably use
a DCHECK unless I'm missing something.

[yefimt, 2012/07/19 20:00:15]

Done.

+  root_ = new views::MenuItemView(this);
+  // We have icons, set this so we get the taller menu style.
+  root_->set_has_icons(true);
+  PopulateMenu();
+  menu_runner_.reset(new views::MenuRunner(root_));
+}
+
+void ActionBoxMenu::RunMenu(views::MenuButton* menu_button) {
+  gfx::Point screen_location;
+  views::View::ConvertPointToScreen(menu_button, &screen_location);
+  // Ignore the result since we don't need to handle a deleted menu specially.
+  ignore_result(
+      menu_runner_->RunMenuAt(menu_button->GetWidget(),
+                              menu_button,
+                              gfx::Rect(screen_location, menu_button->size()),
+                              views::MenuItemView::TOPRIGHT,
+                              views::MenuRunner::HAS_MNEMONICS));
+}
+
+void ActionBoxMenu::ExecuteCommand(int id) {
+};
+
+views::Border* ActionBoxMenu::CreateMenuBorder() {
+  return views::Border::CreateSolidBorder(1, SkColorSetRGB(0, 0, 0));
+}
+
+views::Background* ActionBoxMenu::CreateMenuBackground() {
+  return views::Background::CreateSolidBackground(SkColorSetRGB(255, 255, 255));
+}
+
+Browser* ActionBoxMenu::GetBrowser() const {
+  return browser_;
+}
+
+int ActionBoxMenu::GetCurrentTabId() const {
+  return 0;
+}
+
+void ActionBoxMenu::OnBrowserActionExecuted(BrowserActionButton* button) {
+}
+
+void ActionBoxMenu::OnBrowserActionVisibilityChanged() {
+}
+
+gfx::Size ActionBoxMenu::GetViewContentOffset() const {
+  return gfx::Size(0, 0);
+}
+
+void ActionBoxMenu::WriteDragDataForView(views::View* sender,
+                                         const gfx::Point& press_pt,
+                                         ui::OSExchangeData* data) {
+}
+
+int ActionBoxMenu::GetDragOperationsForView(views::View* sender,
+                                            const gfx::Point& p) {
+  return 0;
+}
+
+bool ActionBoxMenu::CanStartDragForView(views::View* sender,
+                                        const gfx::Point& press_pt,
+                                        const gfx::Point& p) {
+  return false;
+}
+
+void ActionBoxMenu::Observe(int type,
+                            const content::NotificationSource& source,
+                            const content::NotificationDetails& details) {
+}
+
+void ActionBoxMenu::PopulateMenu() {
+  int item_id = 1;
+  AddBookmarkMenuItem(root_, &item_id);
+  if (model_->GetItemCount() > 0)
+    root_->AppendSeparator();
+
+  for (int model_index = 0; model_index < model_->GetItemCount();
+       ++model_index) {
+    views::MenuItemView* menu_item = root_->AppendMenuItemFromModel(
+        model_, model_index, item_id);

[Peter Kasting, 2012/07/18 01:37:25]

Nit: As mentioned previously, if you pass "item_id + model_index" as the last
arg here, you can omit the final increment in this loop (and I think the code is
clearer).

[yefimt, 2012/07/18 23:18:13]

Done.

+    if (model_->GetTypeAt(model_index) == ui::MenuModel::TYPE_COMMAND) {
+      menu_item->SetMargins(0, 0);
+      const extensions::Extension* extension =
+          model_->GetActionBoxExtensionByIndex(model_index);
+      BrowserActionView* view = new BrowserActionView(extension, this);
+      view->button()->SetShowMultipleIconStates(false);
+      view->button()->SetTooltipDisabled(true);
+      browser_action_views_.push_back(linked_ptr<BrowserActionView>(view));
+      menu_item->SetIconView(view);
+    }
+    item_id++;
+  }
+}
+
+views::MenuItemView* ActionBoxMenu::AddBookmarkMenuItem(
+    views::MenuItemView* parent,
+    int* item_id) {
+  string16 label = l10n_util::GetStringUTF16(bookmark_item_state_ ?
+      IDS_TOOLTIP_STARRED : IDS_TOOLTIP_STAR);
+  gfx::ImageSkia* icon =
+      ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
+          bookmark_item_state_ ? IDR_STAR_LIT : IDR_STAR);
+  DCHECK(icon);
+  views::MenuItemView* item =
+      parent->AppendMenuItemWithIcon(*item_id, label, *icon);
+  (*item_id)++;
+  return item;
+}