Action box menu

chrome/browser/ui/views/action_box_menu.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_ACTION_BOX_MENU_H_
+#define CHROME_BROWSER_UI_VIEWS_ACTION_BOX_MENU_H_
+
+#include <map>
+
+#include "base/memory/linked_ptr.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/ui/views/browser_action_view.h"
+#include "content/public/browser/notification_observer.h"
+#include "ui/base/models/menu_model.h"
+#include "ui/views/controls/menu/menu_delegate.h"
+
+class ActionBoxMenuModel;
+
+namespace views {
+class Background;
+class Border;
+class MenuItemView;
+class MenuRunner;
+class View;
+}
+
+// ActionBoxMenu adapts the ActionBoxMenuModel to view's menu related classes.
+class ActionBoxMenu
+    : public views::MenuDelegate,

[Peter Kasting, 2012/07/14 02:08:01]

Nit: Place at end of previous line, indent subsequent lines to match

[yefimt, 2012/07/17 18:20:37]

Done.

+      public BrowserActionView::Delegate,
+      public content::NotificationObserver {
+ public:
+  ActionBoxMenu(Browser* browser, ActionBoxMenuModel* model,

[Peter Kasting, 2012/07/14 02:08:01]

Nit: One arg per line

[yefimt, 2012/07/17 18:20:37]

Done.

+                bool bookmark_item_state);
+  virtual ~ActionBoxMenu();
+
+  void Init();
+
+  // Shows the menu relative to the specified view.

[Peter Kasting, 2012/07/14 02:08:01]

Nit: "specified button" perhaps?

[yefimt, 2012/07/17 18:20:37]

Done.

+  void RunMenu(views::MenuButton* host);

[Peter Kasting, 2012/07/14 02:08:01]

Nit: |host| seems like an odd name, what about |button|?

[yefimt, 2012/07/17 18:20:37]

Done.

+
+ private:
+  // MenuDelegate overrides:
+  virtual void ExecuteCommand(int id) OVERRIDE;
+  virtual views::Border* CreateMenuBorder() OVERRIDE;
+  virtual views::Background* CreateMenuBackground() OVERRIDE;
+
+  // BrowserActionsHostDelegate overrides:
+  virtual Browser* GetBrowser() const OVERRIDE;
+  virtual int GetCurrentTabId() const OVERRIDE;
+  virtual void OnBrowserActionExecuted(BrowserActionButton* button) OVERRIDE;
+  virtual void OnBrowserActionVisibilityChanged() OVERRIDE;
+  virtual gfx::Size GetViewContentOffset() const OVERRIDE;
+
+  // DragController overrides:
+  virtual void WriteDragDataForView(views::View* sender,
+                                    const gfx::Point& press_pt,
+                                    ui::OSExchangeData* data) OVERRIDE;
+  virtual int GetDragOperationsForView(views::View* sender,
+                                       const gfx::Point& p) OVERRIDE;
+  virtual bool CanStartDragForView(views::View* sender,
+                                   const gfx::Point& press_pt,
+                                   const gfx::Point& p) OVERRIDE;
+
+  // NotificationObserver overrides:
+  virtual void Observe(int type,
+                       const content::NotificationSource& source,
+                       const content::NotificationDetails& details) OVERRIDE;
+
+  views::MenuItemView* AddBookmarkMenuItem(views::MenuItemView* parent,
+                                           int* next_id);
+
+  // Populates |parent| with all the child menus in |model|.
+  void PopulateMenu();
+
+  Browser* browser_;
+
+  // The views menu. Owned by |menu_runner_|.
+  views::MenuItemView* root_;
+
+  scoped_ptr<views::MenuRunner> menu_runner_;
+
+  // The model that tracks the order of the toolbar icons.
+  ActionBoxMenuModel* model_;
+
+  bool bookmark_item_state_;
+
+  typedef std::vector<linked_ptr<BrowserActionView> > BrowserActionViews;

[Peter Kasting, 2012/07/14 02:08:01]

Use ScopedVector instead.

Nit: Typedef goes atop the private section.

[yefimt, 2012/07/17 18:20:37]

Actually another reviewer, aa@, insisted to use vector<linked_ptr<...> > instead
of ScopedVector

On 2012/07/14 02:08:01, Peter Kasting wrote:

+  BrowserActionViews browser_action_views_;
+
+  DISALLOW_COPY_AND_ASSIGN(ActionBoxMenu);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_ACTION_BOX_MENU_H_