Action box menu

chrome/browser/extensions/extension_toolbar_model.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_TOOLBAR_MODEL_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_TOOLBAR_MODEL_H_
 #pragma once
 
 #include "base/compiler_specific.h"
 #include "base/observer_list.h"
@@ skipping 74 matching lines @@
     return toolitems_.end();
   }
 
   const extensions::Extension* GetExtensionByIndex(int index) const;
 
   // Utility functions for converting between an index into the list of
   // incognito-enabled browser actions, and the list of all browser actions.
   int IncognitoIndexToOriginal(int incognito_index);
   int OriginalIndexToIncognito(int original_index);
 
+  size_t action_box_extensions_size() {
+    return action_box_menu_items_.size();
+  }
+
+  const extensions::Extension* GetActionBoxExtensionByIndex(int index) const;

[Aaron Boodman, 2012/06/12 05:53:44]

Why not just expose the ExtensionList directly? Consider changing the toolbar
one to do the same.

[yefimt, 2012/06/13 01:24:21]

I'm a bit uncomfortable to do it.
I don't want to return a copy of a list, because caller could  cache it.
Returning a const reference is OK, but I don't see how it is better then current
implementation.
On 2012/06/12 05:53:44, Aaron Boodman wrote:

+
  private:
   // content::NotificationObserver implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
   // To be called after the extension service is ready; gets loaded extensions
   // from the extension service and their saved order from the pref service
   // and constructs |toolitems_| from these data.
-  void InitializeExtensionList();
+  void InitializeExtensionLists();
+  void InitializeExtensionList(const std::vector<std::string>& pref_order,
+      extensions::ExtensionList* extension_list, bool bar);
 
   // Save the model to prefs.
   void UpdatePrefs();
 
   // Our observers.
   ObserverList<Observer> observers_;
 
   void AddExtension(const extensions::Extension* extension);
   void RemoveExtension(const extensions::Extension* extension);
 
   // Our ExtensionService, guaranteed to outlive us.
   ExtensionService* service_;
 
   PrefService* prefs_;
 
   // True if we've handled the initial EXTENSIONS_READY notification.
   bool extensions_initialized_;
 
   // Ordered list of browser action buttons.
   extensions::ExtensionList toolitems_;
 
+  // List of browser action buttons visible in an action box menu.
+  extensions::ExtensionList action_box_menu_items_;
+
   // Keeps track of what the last extension to get disabled was.
   std::string last_extension_removed_;
 
   // Keeps track of where the last extension to get disabled was in the list.
   size_t last_extension_removed_index_;
 
   // The number of icons visible (the rest should be hidden in the overflow
   // chevron).
   int visible_icon_count_;
 
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionToolbarModel);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_TOOLBAR_MODEL_H_