Implement a request cache and disble retrieving a sub-region.

chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/utf_string_conversions.h"
 #include "base/stl_util.h"
 #include "chrome/common/spellcheck_messages.h"
 #include "chrome/renderer/spellchecker/spellcheck_provider.h"
@@ skipping 40 matching lines @@
         text_check_completions_.Lookup(identifier);
     if (!completion) {
       ResetResult();
       return;
     }
     offset_ = offset;
     text_.assign(text);
     text_check_completions_.Remove(identifier);
     completion->didFinishCheckingText(
         std::vector<WebKit::WebTextCheckingResult>());
+    last_request_ = text;
   }
 
   void ResetResult() {
     offset_ = -1;
     text_.clear();
   }
 
   int offset_;
   string16 text_;
   std::vector<IPC::Message*> messages_;
@@ skipping 73 matching lines @@
   EXPECT_EQ(ASCIIToUTF16("First "), provider_.text_);
 
   // Verify that the SpellCheckProvider class spellcheck the first line when we
   // type a return key, i.e. when we finish typing a line.
   provider_.ResetResult();
   provider_.RequestTextChecking(WebKit::WebString("First Second\n"), 0,
                                 &completion);
   EXPECT_EQ(0, provider_.offset_);
   EXPECT_EQ(ASCIIToUTF16("First Second\n"), provider_.text_);
 
-  // Verify that the SpellCheckProvider class spellcheck the second line when we
+  // Verify that the SpellCheckProvider class spellcheck the lines when we
   // finish typing a word "Third" to the second line.
   provider_.ResetResult();
   provider_.RequestTextChecking(WebKit::WebString("First Second\nThird "), 0,
                                 &completion);
-  EXPECT_EQ(13, provider_.offset_);
-  EXPECT_EQ(ASCIIToUTF16("Third "), provider_.text_);
+  EXPECT_EQ(0, provider_.offset_);
+  EXPECT_EQ(ASCIIToUTF16("First Second\nThird "), provider_.text_);
 
   // Verify that the SpellCheckProvider class does not send a spellcheck request
   // when a user inserts whitespace characters.
   provider_.ResetResult();
   provider_.RequestTextChecking(WebKit::WebString("First Second\nThird   "), 0,
                                 &completion);
   EXPECT_EQ(-1, provider_.offset_);
   EXPECT_TRUE(provider_.text_.empty());
 
-  // Verify that the SpellCheckProvider class spellcheck the second line when we
-  // type a period.
+  // Verify that the SpellCheckProvider class spellcheck the lines when we type
+  // a period.
   provider_.ResetResult();
   provider_.RequestTextChecking(
       WebKit::WebString("First Second\nThird   Fourth."), 0, &completion);
-  EXPECT_EQ(13, provider_.offset_);
-  EXPECT_EQ(ASCIIToUTF16("Third   Fourth."), provider_.text_);
+  EXPECT_EQ(0, provider_.offset_);
+  EXPECT_EQ(ASCIIToUTF16("First Second\nThird   Fourth."), provider_.text_);
 }
 
 // Tests that the SpellCheckProvider class cancels incoming spellcheck requests
 // when it does not need to handle them.
 TEST_F(SpellCheckProviderTest,CancelUnnecessaryRequests) {
   int document_tag = 123;
   FakeTextCheckingCompletion completion;
   provider_.RequestTextChecking(WebKit::WebString("hello."),
                                 document_tag,
                                 &completion);
@@ skipping 11 matching lines @@
   // Test that the SpellCheckProvider class cancels an incoming request that
   // does not include any words.
   provider_.RequestTextChecking(WebKit::WebString(":-)"),
                                 document_tag,
                                 &completion);
   EXPECT_EQ(completion.completion_count_, 3U);
   EXPECT_EQ(completion.cancellation_count_, 2U);
 }
 
 }  // namespace